From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25974606A31A for ; Wed, 28 Oct 2026 03:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=4UQz1q8l; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=Jve2qMQH; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=OvFrQE36 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=HwGo/G4gEpUpIo+bKFAsHtueT7AJTgoSavx4bPbu3dI=; b=4UQz1q8lmOoioF9oYqq1c0ctm9 9oTE0kc3MZfW/Rq/+YqInRhPxWgZaJVKTr549W6zrsdltkX/cr8BLNpc+ZH4+yy1dFe5fr7KtD6Sw z8SZ5hcT+eNQKouDyNWQfGlelOQ19pJs/lbF6a04YXgGTSnl7YUH67us6/ap4/Ze8qxL7t5xjJY2M CiGFBj96TrvnFRyT2bYhFKBa86Dbb6z/tsWVWiofEyZ0SoQCJTwLw2pPerokDXf7Ph0Agw7neqMy5 pL+es3+OaMZPqAvXa8K3bGe1yQs+4WbX63/IRFZAiBFP0geIvoqQdCiigHRQns1F2HibsApxATn9r Wgak5rnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLuSk-00000006ELU-0QOe; Wed, 28 Oct 2026 03:36:30 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLuSh-00000006EL5-0eXs for linux-mtd@lists.infradead.org; Wed, 28 Oct 2026 03:36:29 +0000 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69S0isFX3816331 for ; Wed, 28 Oct 2026 03:36:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=Jve2qMQHUqrEssgK LflW6/l7KZ234zJVmm5v4avWWbV1TcUiioz11IU7xNAS3yhP+6JpgpsoOMhZWZvJ IPei/BNfJ7ExWg/tShStITm6QZsRQXDRsGswXFZFnq+o9ga6nmbSa33m3OhRLXWT jNycF1Ub6eUUeiAVgYu5ZaX6svI7KSL3EU6+K53Rnc/d554YMUVQJALzktVCxxiV q+Kz86xf3mp9SK5/sBZk8qiecR2lpX8aT+GhaHVmok95F2t7X+5DAAukw34dJtRr PnVGLMYR/XaeQ9zEg45sqiPgK2kxAakvx9jugL9konNgiu/4GNvqT3B3MXccU96s aGnIQQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hjst1ktmb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Oct 2026 03:36:25 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8a064f294cbso383168b3a.2 for ; Tue, 27 Oct 2026 20:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793158585; x=1793763385; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=OvFrQE36qo55+qIF4kkA5dVWZMhJ+0fSxp5R2q0F27otWY9nhyNzdhngcsj6MRCxCD eVzKh5MQb2wN8bIwMuJUH0LexgXZsV20DOfBr0kQR5/Jqv5/RKNMV1mZt2GJudytdPyL L5IW5ZiZbw+O0c5zZTYbX0bxG+2MWD8ErG430QmDndCdJ5e0hInGuIQk+TmSjaqQ6934 Rn9M2Sn/wV5mSFzXl1AS9eL6aY+hLAesFensGph03FGMyThGCIaNEXDSvkoPgPmkDenu WnC1bQrnG2OYgSJUABSdbbPkxK3rnwVEwtbiwiS802zzG2iv9vQajRWyANUyjgZxkOJx wiqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793158585; x=1793763385; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=AlztOoUEEG6EsahL7GCyiGDYksfnV9exNUg+NR2VIOPNApM43IIxPv5IvLxHhd9WKx Kda2OhJnYA6nrJASXAuK+I4Y2ky0Tcf4ygGgxF3uaGDr8Utn5NRcj7yYu9bbJP3FlZzO 7W7LuKEhOAfhWHN7YsZSyjQxCw+NBCDJe5ps6HmhJv+D/cLDlqPYkPC/bJbh1dMJvruV xoUzC6/lxtcqXBDNjkE1XiGGMevJDcmmWrNawlZG/sWLleuXw3j9uCITqYffhb9CAjcn xS9+hzuM+4hlEF31mBxWn9G/UhQxtQxJwi12zB3CC1FjbPwojGRXUoXvZZCJifu6XKHr FW3Q== X-Forwarded-Encrypted: i=1; AKwUvBz8Gm/0kHXV2JqlzL/HY2IIStqbhbFY9HIhKr8Gd5/sWOACoql0z3BhOusYB40PNkhgtvu0JJOds/U=@lists.infradead.org X-Gm-Message-State: AFq9FYIBxDDGAAERzbnOGl6x06t9tCKmJNP0iJjxlVcV6yhQ9xVSumXk FeT8h+OORc3d9cvCyp1ouLAgo4DTtPF86gvpbMuWgDUmm6sunFkbiTH5WN91K3kkIzvq4uQz1MY x+W+TF1J7zOPf1RNxF8VmfYPTNgpyRLimrdE5IuJ9U5PZAkQKO9HzbAl/Md80ZsIul0xd X-Gm-Gg: AYBFou3KOp+C3TaJ6JIuF2ZUuPDX/I1kDmfrn67uTZSrmIfRL+ckuM04Mk5HrTPmaWC hLCjllvLZB6201D8QEoMj1jvRW0zaZXCh7/8e/p2GTmZSrYeLAS3+tA+MPU1oM+25OHyPhxSqkQ vecje/Zy6rGrajaq6Xm5ajnMqi9Jir4ka7pUe3joZibzqdckniAv5eVES9DME2kdMNOKq4nH4H4 k7W9QmC1xyLFpKd7O4vp84bPtQYVu2qu4cra4cqagdg2enRIBPj9bqv1O7MISIH9z698jagmfzs 4V9fG25oNMneqtpTpnpanCTrFkNBOt0YXYKPJOxh5C3z02f/SS4M90z80mhhgDSzgBbanimugr8 u7+oOi7r7jF6CYc/3PHMG2xozi7mItUocM+8FOJ73fW8582B0OfD6bONslawA4yaqxeJOKZIKZP VuaPQHeGcTQlzpyiiORZ8gCITQ1yqhTncyeRakdR0GABg= X-Received: by 2002:a17:90b:5863:b0:3ac:b3ff:b476 with SMTP id 98e67ed59e1d1-3ae581836a6mr818182a91.38.1793158585059; Tue, 27 Oct 2026 20:36:25 -0700 (PDT) X-Received: by 2002:a17:90b:5863:b0:3ac:b3ff:b476 with SMTP id 98e67ed59e1d1-3ae581836a6mr818144a91.38.1793158584441; Tue, 27 Oct 2026 20:36:24 -0700 (PDT) Received: from [10.133.33.27] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae5a48ec90sm899533a91.6.2026.10.27.20.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2026 20:36:24 -0700 (PDT) Message-ID: Date: Wed, 28 Oct 2026 11:36:16 +0800 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/9] cpufreq: governor: Initialize kobj_type release callback statically To: Ian Rogers , Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , =?UTF-8?Q?Christian_K=C3=B6nig?= , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Viresh Kumar , zhongqiu.han@oss.qualcomm.com References: <20261027223847.652884-1-irogers@google.com> <20261027223847.652884-5-irogers@google.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20261027223847.652884-5-irogers@google.com> X-Authority-Analysis: v=2.4 cv=HJ1WhYtv c=1 sm=1 tr=0 ts=6ae16db9 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=1XWaLZrsAAAA:8 a=MbyaxBA4Lnn_ULkWIDkA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: KKIBIFfFW0JZwROdIoBN_DMXSI8ElAca X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI4MDAxNCBTYWx0ZWRfX3GUKs6g/zqFo zzMTTyc2/46PcVSKyNemv4E5EgGw4AJ8q2ANcBiy/mUsEC4jRvfSMlIH6JLmfpR5vduKQ46am4Z TQf0Qao6hlsYNZ37UFIQtj9TZF7yIaE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI4MDAxNCBTYWx0ZWRfX9+/0jBXMGo2W ibQXjm2S5zhnG1heCrB+X42zdKkKOlfMAfedv80quhNhwN+3hFz3hhTVKHfjyKnlMsuswVycINq SmhzopAI7oEVK8ABrxKqbHIeQ3E+OVblH8qelVoTYejvUcMjFs54DgNYGI/8eDdOlkKLlZpQtty 5x1qohb7nrU0Qykmex/AmOoVbhsdiYTM7udmjWeU92RspfInMAPYgI2kIHa15Oji3ggMkJRoNvD 7hrVVFKHhbJ+dor3pQGx+8PS57Zqu1QnxXEf4XlwPbgW/4Mn+iKI31aSYm8HOxX2kVHKsEF7gyW QFD6Og+2yYHxLPXA3yuYtQv05l7g06adCDGRpzFhuNRgO5AdDnjGEEYqNW/vefCw71H4+fUh/oP x1X1s7TgB8PAGT6cwSskQL3kC26OhiIYiXuCFFtP929xU+dKK8ZW4eZzHGCNAnB8KNF6yY8RkEU bml7h4jm2++0LK4osWg== X-Proofpoint-GUID: KKIBIFfFW0JZwROdIoBN_DMXSI8ElAca X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-28_01,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610280014 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261027_203627_213176_A2F95DB6 X-CRM114-Status: GOOD ( 24.54 ) X-Spam-Score: -2.8 (--) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Hi Ian, Thanks for the update. On 10/28/2026 6:38 AM, Ian Rogers wrote: > Export cpufreq_dbs_data_release() and set .kobj_type.release statically > in the ondemand and conservative governors so their gov_attr_set > kobjects have a valid release callback statically initialized, matching > cpufreq_governor_dbs. Remove the redundant runtime assignment in "matching cpufreq_governor_dbs" is a bit confusing to me (cpufreq_governor_dbs() was removed back in v4.8 by commit e788892ba3cc ("cpufreq: governor: Get rid of governor events")), as it doesn't seem to refer to anything in the tree. Perhaps we could just drop it, e.g.: Export cpufreq_dbs_data_release() and initialize .kobj_type.release statically in the ondemand and conservative governors instead of assigning it at runtime in cpufreq_dbs_governor_init(). The code change itself looks good to me. With the changelog updated (in a respin if the series needs one for other reasons, or when applying): Reviewed-by: Zhongqiu Han > cpufreq_dbs_governor_init(). > > This prepares for annotating struct kobj_type::release with > __must_init. > > Signed-off-by: Ian Rogers > --- > drivers/cpufreq/cpufreq_conservative.c | 5 ++++- > drivers/cpufreq/cpufreq_governor.c | 4 ++-- > drivers/cpufreq/cpufreq_governor.h | 1 + > drivers/cpufreq/cpufreq_ondemand.c | 5 ++++- > 4 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c > index 02bfd46543e9..146a2353b1a2 100644 > --- a/drivers/cpufreq/cpufreq_conservative.c > +++ b/drivers/cpufreq/cpufreq_conservative.c > @@ -318,7 +318,10 @@ static void cs_limits(struct cpufreq_policy *policy) > > static struct dbs_governor cs_governor = { > .gov = CPUFREQ_DBS_GOVERNOR_INITIALIZER("conservative"), > - .kobj_type = { .default_groups = cs_groups }, > + .kobj_type = { > + .release = cpufreq_dbs_data_release, > + .default_groups = cs_groups, > + }, > .gov_dbs_update = cs_dbs_update, > .alloc = cs_alloc, > .free = cs_free, > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c > index f3bd3dbe7c41..f8b5aca09b6b 100644 > --- a/drivers/cpufreq/cpufreq_governor.c > +++ b/drivers/cpufreq/cpufreq_governor.c > @@ -419,7 +419,7 @@ static void free_policy_dbs_info(struct policy_dbs_info *policy_dbs, > gov->free(policy_dbs); > } > > -static void cpufreq_dbs_data_release(struct kobject *kobj) > +void cpufreq_dbs_data_release(struct kobject *kobj) > { > struct dbs_data *dbs_data = to_dbs_data(to_gov_attr_set(kobj)); > struct dbs_governor *gov = dbs_data->gov; > @@ -427,6 +427,7 @@ static void cpufreq_dbs_data_release(struct kobject *kobj) > gov->exit(dbs_data); > kfree(dbs_data); > } > +EXPORT_SYMBOL_GPL(cpufreq_dbs_data_release); > > int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) > { > @@ -488,7 +489,6 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) > policy->governor_data = policy_dbs; > > gov->kobj_type.sysfs_ops = &governor_sysfs_ops; > - gov->kobj_type.release = cpufreq_dbs_data_release; > ret = kobject_init_and_add(&dbs_data->attr_set.kobj, &gov->kobj_type, > get_governor_parent_kobj(policy), > "%s", gov->gov.name); > diff --git a/drivers/cpufreq/cpufreq_governor.h b/drivers/cpufreq/cpufreq_governor.h > index 806d8fb4dff1..1026712bb79b 100644 > --- a/drivers/cpufreq/cpufreq_governor.h > +++ b/drivers/cpufreq/cpufreq_governor.h > @@ -150,6 +150,7 @@ static inline struct dbs_governor *dbs_governor_of(struct cpufreq_policy *policy > } > > /* Governor callback routines */ > +void cpufreq_dbs_data_release(struct kobject *kobj); > int cpufreq_dbs_governor_init(struct cpufreq_policy *policy); > void cpufreq_dbs_governor_exit(struct cpufreq_policy *policy); > int cpufreq_dbs_governor_start(struct cpufreq_policy *policy); > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c > index 9942dbb38dae..7386d043c665 100644 > --- a/drivers/cpufreq/cpufreq_ondemand.c > +++ b/drivers/cpufreq/cpufreq_ondemand.c > @@ -374,7 +374,10 @@ static struct od_ops od_ops = { > > static struct dbs_governor od_dbs_gov = { > .gov = CPUFREQ_DBS_GOVERNOR_INITIALIZER("ondemand"), > - .kobj_type = { .default_groups = od_groups }, > + .kobj_type = { > + .release = cpufreq_dbs_data_release, > + .default_groups = od_groups, > + }, > .gov_dbs_update = od_dbs_update, > .alloc = od_alloc, > .free = od_free, -- Thx and BRs, Zhongqiu Han ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/