From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cmCY0-0001OS-Ap for linux-mtd@lists.infradead.org; Fri, 10 Mar 2017 04:53:03 +0000 Received: by mail-wm0-x241.google.com with SMTP id u132so448471wmg.1 for ; Thu, 09 Mar 2017 20:52:39 -0800 (PST) Subject: Re: [PATCH v2 1/2] doc: bindings: Add bindings documentation for mtd nvmem To: Moritz Fischer References: <1488875164-30440-1-git-send-email-albeu@free.fr> <1488875164-30440-2-git-send-email-albeu@free.fr> <9f54978c-6d61-cf2c-fb2d-f5ef2af19e0f@gmail.com> Cc: Alban , Linux Kernel Mailing List , Srinivas Kandagatla , Maxime Ripard , Rob Herring , Mark Rutland , David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , Cyrille Pitchen , Devicetree List , linux-mtd@lists.infradead.org From: Marek Vasut Message-ID: Date: Fri, 10 Mar 2017 05:52:36 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03/10/2017 05:06 AM, Moritz Fischer wrote: > On Thu, Mar 9, 2017 at 7:17 PM, Marek Vasut wrote: >> On 03/07/2017 09:26 AM, Alban wrote: >>> Config data for drivers, like MAC addresses, is often stored in MTD. >>> Add a binding that define how such data storage can be represented in >>> device tree. >>> >>> Signed-off-by: Alban >>> --- >>> Changelog: >>> v2: * Added a "Required properties" section with the nvmem-provider >>> property >>> --- >>> .../devicetree/bindings/nvmem/mtd-nvmem.txt | 33 ++++++++++++++++++++++ >>> 1 file changed, 33 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt >>> >>> diff --git a/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt >>> new file mode 100644 >>> index 0000000..8ed25e6 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt >>> @@ -0,0 +1,33 @@ >>> += NVMEM in MTD = >>> + >>> +Config data for drivers, like MAC addresses, is often stored in MTD. >>> +This binding define how such data storage can be represented in device tree. >>> + >>> +An MTD can be defined as an NVMEM provider by adding the `nvmem-provider` >>> +property to their node. Data cells can then be defined as child nodes >>> +of the partition as defined in nvmem.txt. >> >> Why don't we just read the data from MTD and be done with it ? What's >> the benefit of complicating things by using nvmem ? > > Well because usually stuff like MAC addresses etc are stored in eeproms. But eeproms are already supported, see drivers/misc/ . > This gives a nice abstraction with making them both look like nvmem (that was my > reasoning back then when I submitted a patch to support the OTP part in a > SPI NOR part. Hm, I am confused here, we're mixing SPI NOR, EEPROMs and OTP devices here. -- Best regards, Marek Vasut