From: Florian Fainelli <f.fainelli@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Brian Norris" <computersforpeace@gmail.com>,
"Kamal Dasu" <kdasu.kdev@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Cai Huoqing" <caihuoqing@baidu.com>,
"Colin Ian King" <colin.king@intel.com>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:BROADCOM SPECIFIC AMBA DRIVER (BCMA)"
<linux-wireless@vger.kernel.org>,
"open list:BROADCOM STB NAND FLASH DRIVER"
<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH 5/9] mtd: rawnand: brcmnand: Allow working without interrupts
Date: Mon, 27 Dec 2021 09:05:52 -0800 [thread overview]
Message-ID: <ee2d9730-6f7c-a210-8949-0eb2edd9b22e@gmail.com> (raw)
In-Reply-To: <CAHp75VeLAuGbeh+DJ=Oox5o8vdt=iLxr80sS3RrZbdJ9smh4OA@mail.gmail.com>
On 12/25/2021 9:45 AM, Andy Shevchenko wrote:
> On Sat, Dec 25, 2021 at 1:41 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>> The BCMA devices include the brcmnand controller but they do not wire up
>> any interrupt line, allow the main interrupt to be optional and update
>> the completion path to also check for the lack of an interrupt line.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
>> - unsigned int irq;
>> + int irq;
>
> instead.,,
>
>> + ctrl->irq = platform_get_irq_optional(pdev, 0);
>> + if (ctrl->irq >= 0) {
>
> ret = ...
> if (ret > 0) {
>
> And drop 0 from the equation, OF never uses 0 as valid vIRQ.
OK but the point of this patch series is to allow the use of the
brcmnand driver in a configuration without OF. I don't really see the
point in continuing to use unsigned int instead of just letting
request_irq() play through and tell us if the interrupt descriptor was
valid later on.
--
Florian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-12-27 17:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 0:22 [PATCH 0/9] BCMA support for brcmnand Florian Fainelli
2021-12-23 0:22 ` [PATCH 1/9] mtd: rawnand: brcmnand: Allow SoC to provide I/O operations Florian Fainelli
2022-01-03 16:49 ` Miquel Raynal
2022-01-03 17:24 ` Florian Fainelli
2022-01-04 8:32 ` Miquel Raynal
2022-01-04 8:57 ` Miquel Raynal
2022-01-04 18:34 ` Florian Fainelli
2022-01-04 18:37 ` Miquel Raynal
2021-12-23 0:22 ` [PATCH 2/9] mtd: rawnand: brcmnand: Assign soc as early as possible Florian Fainelli
2021-12-23 0:22 ` [PATCH 3/9] mtd: rawnand: brcmnand: Avoid pdev in brcmnand_init_cs() Florian Fainelli
2021-12-23 0:22 ` [PATCH 4/9] mtd: rawnand: brcmnand: Move OF operations out of brcmnand_init_cs() Florian Fainelli
2022-01-03 16:56 ` Miquel Raynal
2022-01-03 17:27 ` Florian Fainelli
2022-01-04 8:30 ` Miquel Raynal
2021-12-23 0:22 ` [PATCH 5/9] mtd: rawnand: brcmnand: Allow working without interrupts Florian Fainelli
2021-12-25 17:45 ` Andy Shevchenko
2021-12-27 17:05 ` Florian Fainelli [this message]
2021-12-23 0:22 ` [PATCH 6/9] mtd: rawnand: brcmnand: Add platform data structure for BCMA Florian Fainelli
2021-12-23 0:22 ` [PATCH 7/9] mtd: rawnand: brcmnand: Allow platform data instantation Florian Fainelli
2021-12-23 0:22 ` [PATCH 8/9] mtd: rawnand: brcmnand: BCMA controller uses command shift of 0 Florian Fainelli
2021-12-23 0:22 ` [PATCH 9/9] mtd: rawnand: brcmnand: Add BCMA shim Florian Fainelli
2022-01-03 17:06 ` Miquel Raynal
2022-01-03 17:28 ` Florian Fainelli
2022-01-03 17:12 ` Miquel Raynal
2022-01-03 17:28 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee2d9730-6f7c-a210-8949-0eb2edd9b22e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=caihuoqing@baidu.com \
--cc=colin.king@intel.com \
--cc=computersforpeace@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).