Re: spi-nor: maxronix MX25L12835F support

Tudor.Ambarus
2021-03-01T14:10:12Z

On 3/1/21 3:50 PM, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Am 2021-03-01 14:36, schrieb Pratyush Yadav:
>> I think printing the correct flash name is somewhat important. Other
>> than the handful of people who are reading this thread, few would know
>> that SPI NOR calls mx25l12835f as mx25l12805d or vice versa. This can
>> cause a lot of confusion among people trying to debug any issues.
>
> Unfortunately, this is kind of a mess. If multiple flash devices
> share the same id, it seems to be first come first serve. The kernel
> will print the name which was introduced first.
>
> This isn't the only flash which is affected. Have a look at
>   drivers/mtd/spi-nor/winbond.c
> There are all kind of flash names, some of them are not even existing
> as this particular string, eg. take w25q64jwm, its actually "Winbond
> W25Q64JW-IM or W25Q64JW-JM".
>
> So yes, it would be nice to have such a thing, but for now, I will
> take the kernel output as a rough estimation what might really be
> used on the board.
>

How about naming them something like "updated-flash-name || first-name".
Anyway, these are just workarounds. Manufacturers shouldn't use the same
JEDEC ID for new flashes. They should at least add an extended ID.