From: Michael Walle <michael@walle.cc>
To: David Bauer <mail@david-bauer.net>
Cc: tudor.ambarus@microchip.com, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: spi-nor: Add support for BoHong bh25q128as
Date: Mon, 10 May 2021 11:35:32 +0200 [thread overview]
Message-ID: <ef20e03c43d2eacff7133f74a118ea43@walle.cc> (raw)
In-Reply-To: <796a15bd-66d9-b1a5-2258-b692f23364fe@david-bauer.net>
Hi David,
Am 2021-05-10 11:28, schrieb David Bauer:
> On 5/10/21 10:00 AM, Michael Walle wrote
>
> [...]
>
>>> +static const struct flash_info bohong_parts[] = {
>>> + /* BoHong Microelectronics */
>>> + { "bh25q128as", INFO(0x684018, 0, 64 * 1024, 256,
>>
>> I couldn't find "BoHong" in JEP106BC. 0x68 (without continuation
>> codes)
>> is "Convex Computer". So this is wrong. OTOH I'm not sure, how many
>> SPI flashes "convex computer" have, if any ;) This company was brought
>> by HP in the end.
>>
>> In any case, this patch depends on how we handle continuation codes or
>> if we can handle them at all. Or if this flash just lie about its
>> manufacturer id and don't and CC.
>
> First of all, BoHong and Boya microelectronics seems to be the same
> company, as their datasheets seem to copy each other. There's not much
> information about either of both, so I'd say that's a fair assumption.
>
> Regarding the continuation codes, Boya is listed in bank nine, however
> in this case I should currently read an all 0x7f ID shouldn't I?
I'd guess so, yes.
> The datasheet also only specifies 3 bytes as a return value for
> register 0x9fh :(
Yeah. So, this flash falls into the same category "simply hijacks
a manuf id" as all the other flashes.
We still need to come up with a solution for this problem.
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-05-10 9:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 14:47 [PATCH] mtd: spi-nor: Add support for BoHong bh25q128as David Bauer
2021-05-10 8:00 ` Michael Walle
2021-05-10 9:28 ` David Bauer
2021-05-10 9:35 ` Michael Walle [this message]
2021-05-10 10:27 ` David Bauer
2021-05-10 10:56 ` Michael Walle
2021-05-10 11:04 ` David Bauer
2021-05-10 11:22 ` Michael Walle
2021-05-18 19:39 ` David Bauer
2021-06-28 5:48 ` Tudor.Ambarus
2021-07-02 14:03 ` Tudor.Ambarus
2021-07-03 15:58 ` George Brooke
2021-07-03 16:20 ` Michael Walle
-- strict thread matches above, loose matches on Subject: below --
2024-02-17 12:20 Christian Marangi
2024-02-19 8:35 ` Michael Walle
2024-02-19 21:56 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef20e03c43d2eacff7133f74a118ea43@walle.cc \
--to=michael@walle.cc \
--cc=linux-mtd@lists.infradead.org \
--cc=mail@david-bauer.net \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox