From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cRQxo-0000t3-DZ for linux-mtd@lists.infradead.org; Wed, 11 Jan 2017 22:01:50 +0000 Received: by mail-wm0-x244.google.com with SMTP id r144so1069285wme.0 for ; Wed, 11 Jan 2017 14:01:26 -0800 (PST) Subject: Re: [PATCH 00/18] MTD-CFI: Fine-tuning for several function implementations To: SF Markus Elfring , linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Denys Vlasenko , Richard Weinberger References: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Cc: kernel-janitors@vger.kernel.org, LKML From: Marek Vasut Message-ID: Date: Wed, 11 Jan 2017 22:58:27 +0100 MIME-Version: 1.0 In-Reply-To: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/11/2017 09:34 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 11 Jan 2017 21:21:12 +0100 > > Several update suggestions were taken into account > from static source code analysis. The patch listing doesn't seem to match the content of the patchset ? The $subject are different ... > Markus Elfring (18): > Use kmalloc_array() in cfi_intelext_partition_fixup() > Improve another size determination in cfi_intelext_partition_fixup() > cfi_cmdset_0001: Add some spaces for better code readability > cfi_cmdset_0001: Delete an unnecessary variable initialisation in do_write_oneword() > cfi_cmdset_0001: Use common error handling code in do_write_oneword() > Use kcalloc() in cfi_intelext_setup() > One function call and an unnecessary check less in cfi_intelext_setup() > Rename a jump label in cfi_intelext_setup() > Use kmalloc_array() in cfi_amdstd_setup() > One function call less in cfi_amdstd_setup() after error detection > Rename a jump label in cfi_amdstd_setup() > cfi_cmdset_0002: Add some spaces for better code readability > cfi_cmdset_0002: Delete an unnecessary variable initialisation in do_write_oneword() > cfi_cmdset_0002: Use common error handling code in do_write_oneword() > Use kcalloc() in cfi_ppb_unlock() > Use kmalloc_array() in cfi_staa_setup() > Use common error handling code in cfi_staa_setup() > cfi_cmdset_0020: Add some spaces for better code readability > > drivers/mtd/chips/cfi_cmdset_0001.c | 165 +++++++++++++++++++----------------- > drivers/mtd/chips/cfi_cmdset_0002.c | 110 +++++++++++++----------- > drivers/mtd/chips/cfi_cmdset_0020.c | 127 ++++++++++++++------------- > 3 files changed, 214 insertions(+), 188 deletions(-) > -- Best regards, Marek Vasut