From: Michael Walle <michael@walle.cc>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v4] mtd: spi-nor: fix memory leak when using debugfs_lookup()
Date: Wed, 08 Feb 2023 17:15:41 +0100 [thread overview]
Message-ID: <f60870dee13900252e0b13fb2f5f05b5@walle.cc> (raw)
In-Reply-To: <20230208160230.2179905-1-gregkh@linuxfoundation.org>
Am 2023-02-08 17:02, schrieb Greg Kroah-Hartman:
> When calling debugfs_lookup() the result must have dput() called on it,
> otherwise the memory will leak over time. To solve this, remove the
> lookup and create the directory on the first device found, and then
> remove it when the module is unloaded.
>
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: Pratyush Yadav <pratyush@kernel.org>
> Cc: Michael Walle <michael@walle.cc>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Michael Walle <michael@walle.cc>
one nit below I didn't notice earlier, no need to send a new
patch version just for that.
..
> +void spi_nor_debugfs_shutdown(void)
> +{
> + if (rootdir)
> + debugfs_remove(rootdir);
debugfs_remove() already has a check for NULL.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-02-08 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 16:02 [PATCH v4] mtd: spi-nor: fix memory leak when using debugfs_lookup() Greg Kroah-Hartman
2023-02-08 16:15 ` Michael Walle [this message]
2023-02-08 17:30 ` Greg Kroah-Hartman
2023-03-06 6:52 ` Greg Kroah-Hartman
2023-03-06 8:33 ` Miquel Raynal
2023-03-06 9:13 ` Greg Kroah-Hartman
2023-03-06 11:05 ` Miquel Raynal
2023-03-17 8:44 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f60870dee13900252e0b13fb2f5f05b5@walle.cc \
--to=michael@walle.cc \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox