Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

Miquel Raynal
2022-12-02T10:54:34Z

Hi Francesco,

francesco@dolcini.it wrote on Fri, 2 Dec 2022 11:24:29 +0100:

> On Fri, Dec 02, 2022 at 11:12:43AM +0100, Francesco Dolcini wrote:
> > Hello Miquel,
> >
> > On Fri, Dec 02, 2022 at 10:14:18AM +0100, Miquel Raynal wrote:
> > > francesco@dolcini.it wrote on Fri, 2 Dec 2022 08:19:00 +0100:
> > > > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > >
> > > > Add a fallback mechanism to handle the case in which #size-cells is set
> > > > to <0>. According to the DT binding the nand controller node should have
> > > > set it to 0 and this is not compatible with the legacy way of
> > > > specifying partitions directly as child nodes of the nand-controller node.
> > >
> > > I understand the problem, I understand the fix, but I have to say, I
> > > strongly dislike it :) Touching an mtd core driver to fix a single
> > > broken use case like that is... problematic, for the least.
> > I just noticed it 2 days after this patch was backported to a stable
> > kernel, I am just the first one to notice, we are not talking about a single
> > use case.
> >
> > > I am sorry but if a 6.0 kernel breaks because:
> > Not only kernel 6.0 is currently broken. This patch is going to be
> > backported to any stable kernel given the fixes tag it has.
> >
> > > If you really want to workaround U-Boot, either you revert that patch
> > > or you just fix the DT description instead. The parent/child/partitions
> > > scheme has been enforced for maybe 5 years now and for a good reason: a
> > > NAND controller with partitions does not make _any_ sense. There are
> > > plenty of examples out there, imx7-colibri.dtsi has received many
> > > updates since its introduction (for the best), so why not this one?
> >
> > I can and I will update imx7-colibri.dtsi (patch coming),

:thumb_up:

> > but is this
> > good enough given the kind of boot failure regression this introduce? We
> > are going to have old u-boot around that will not work with it, and the
>
> Just another piece of information, support for the partitions node in
> U-Boot was added in version v2022.04 [1], we are not talking about ancient
> old legacy stuff.

If it is so recent, then this is what needs to be fixed, and it should
not bother "many" people because 2022.04 is not so old.

So I am a bit lost, IIUC what is currently broken is:
- U-Boot > 2022.04 and any version of Linux with the backport?

> If I add the partitions node as a child of my nand controller, as I was
> planning to do and I wrote 10 lines above, I will create a new flavor of
> non-booting system with U-Boot older than v2022.04 :-/

I think there is a little confusion here. You are referring to the NAND
controller node, the commit refers to the NAND chip node. What this
commit does looks fine because it just tries to use the partitions {}
node rather than the NAND chip node and if the partitions {} node
already exist, I expect #address-cells and #size-cells to be defined
and be != 0 already.

Here is a proper description:

nand-controller {
#address-cells = <1>;
#size-cells = <0>;
nand-chip {
partitions {
#address-cells = <1 or 2>;
#size-cells = <1 or 2>;
partition@x { };
partition@y { };
};
};

/* Here you can very well have another nand-chip node with
* another reg property which represents its own CS and another
* set of partitions.
*/
};

> U-Boot older than v2022.04 will update the nand controller node never
> the less, the partition node will still be there and Linux will use it,
> but it will be empty since nobody populate it.
>
> Francesco
>
> [1] commit 36fee2f7621e ("common: fdt_support: add support for "partitions" subnode to fdt_fixup_mtdparts()")

Thanks,
Miquèl