From: Russ Dill <russ.dill@gmail.com>
To: linux-mtd@lists.infradead.org
Subject: RedBoot FIS Directory parsing bails out early
Date: Tue, 23 Aug 2005 15:47:41 -0700 [thread overview]
Message-ID: <f9d2a5e1050823154740e66385@mail.gmail.com> (raw)
Deleted partitions cause the FIS directory parsing to bail out early,
this is because in redboot, deleting a partition causes the first byte
in the entry to be set to 0xff. The kernel is currently looking for
0xff as an end of table marker.
This means that if you create two partitions, ie, test1 and test2, and
then delete test1, the kernel will no longer detect test1.
redboot.c should instead scan every entry in the FIS table, and throw
out any entries that begin with 0xff, ie, change the break to a
continue. The checksum check should also be changed from a break to a
continue (even though checksums in fis tables were never implemented
anyway).
pseudo patch:
struct fis_list *new_fl, **prev
if (buf[i].name[0] == 0xff)
- break;
+ continue;
if (!redboot_checksum(&buf[i]))
- break;
+ continue;
next reply other threads:[~2005-08-23 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 22:47 Russ Dill [this message]
2005-08-24 0:17 ` RedBoot FIS Directory parsing bails out early Thomas Gleixner
2005-08-24 0:50 ` Russ Dill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9d2a5e1050823154740e66385@mail.gmail.com \
--to=russ.dill@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox