Re: [PATCH next 2/2] mtd: rawnand: mtk: Fix init error path

From: Matthias Brugger <matthias.bgg@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org
Cc: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	linux-arm-kernel@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH next 2/2] mtd: rawnand: mtk: Fix init error path
Date: Fri, 6 Sep 2024 17:01:56 +0200	[thread overview]
Message-ID: <fd7558e1-9af0-4df1-8412-06226f1d96b5@kernel.org> (raw)
In-Reply-To: <20240826153019.67106-2-miquel.raynal@bootlin.com>


On 26/08/2024 17:30, Miquel Raynal wrote:
> Reviewing a series converting the for_each_chil_of_node() loops into
> their _scoped variants made me realize there was no cleanup of the
> already registered NAND devices upon error which may leak memory on
> systems with more than a chip when this error occurs. We should call the
> _nand_chips_cleanup() function when this happens.
> 
> Fixes: Fixes: 1d6b1e464950 ("mtd: mediatek: driver for MTK Smart Device")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Reviewed-by: Matthias Brugger <matthias.bgg@kernel.org>

> ---
> Backporting this change will probably fail. In practice, the memory leak
> is very unlikely to happen so I guess we can live without it.
> ---
>   drivers/mtd/nand/raw/mtk_nand.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c
> index bf845dd16737..586868b4139f 100644
> --- a/drivers/mtd/nand/raw/mtk_nand.c
> +++ b/drivers/mtd/nand/raw/mtk_nand.c
> @@ -1453,8 +1453,10 @@ static int mtk_nfc_nand_chips_init(struct device *dev, struct mtk_nfc *nfc)
>   
>   	for_each_child_of_node_scoped(np, nand_np) {
>   		ret = mtk_nfc_nand_chip_init(dev, nfc, nand_np);
> -		if (ret)
> +		if (ret) {
> +			mtk_nfc_nand_chips_cleanup(nfc);
>   			return ret;
> +		}
>   	}
>   
>   	return 0;

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/