From: Nahor <nahor.j+gmane@gmail.com>
To: linux-mtd@lists.infradead.org
Subject: [PATH] [MTD-UTILS] Return error if failure when reading from standard input
Date: Thu, 04 Jun 2009 10:23:22 -0700 [thread overview]
Message-ID: <h08vuc$uut$1@ger.gmane.org> (raw)
The test to return SUCCESS or FAILURE at the end of nandwrite is done
only when reading from a file. When reading from the standard input,
nandwrite always returns success except for some cases at the begining.
This patches aims at fixing that by returning an error when jumping to
the closeall label.
Regards,
Nahor
--- a/nandwrite.c 2009-06-01 18:03:55.000000000 -0700
+++ b/nandwrite.c 2009-06-03 17:25:19.000000000 -0700
@@ -261,6 +261,7 @@
int oobinfochanged = 0;
struct nand_oobinfo old_oobinfo;
int readcnt = 0;
+ bool failed = true;
process_options(argc, argv);
@@ -623,6 +624,8 @@
mtdoffset += meminfo.writesize;
}
+ failed = false;
+
closeall:
close(ifd);
@@ -637,7 +640,7 @@
close(fd);
- if ((ifd != STDIN_FILENO) && (imglen > 0)) {
+ if (failed || ((ifd != STDIN_FILENO) && (imglen > 0))) {
perror ("Data was only partially written due to error\n");
exit (EXIT_FAILURE);
}
next reply other threads:[~2009-06-04 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 17:23 Nahor [this message]
2009-06-08 6:16 ` [PATH] [MTD-UTILS] Return error if failure when reading from standard input Artem Bityutskiy
2009-06-08 16:32 ` Jehan Bing
2009-06-09 12:39 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='h08vuc$uut$1@ger.gmane.org' \
--to=nahor.j+gmane@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox