From: MikeW <mw_phil@yahoo.co.uk>
To: linux-mtd@lists.infradead.org
Subject: Re: Strange automatic GC threshold ?
Date: Mon, 19 Mar 2007 16:49:24 +0000 (UTC) [thread overview]
Message-ID: <loom.20070319T174627-836@post.gmane.org> (raw)
In-Reply-To: 1174321009.26465.266.camel@gentoo-jocke.transmode.se
Joakim Tjernlund <joakim.tjernlund <at> transmode.se> writes:
>
> In jffs2_thread_should_wake() there is this test to
> wake up GC thread:
>
> if (c->nr_free_blocks + c->nr_erasing_blocks < c->resv_blocks_gctrigger &&
> (dirty > c->nospc_dirty_size))
>
> The && in the above if means that no matter how dirty the FS is, it wont
> trigger GC until there is a very low count of free blocks as well(24 in my
> case out of 1003). I wonder if that && should be a || instead?
>
> Jocke
In the interests of clarity and robustness to edits, there should
be ( ) around the comparison subexpression at any rate.
Regards,
MikeW
next prev parent reply other threads:[~2007-03-19 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 16:16 Strange automatic GC threshold ? Joakim Tjernlund
2007-03-19 16:49 ` MikeW [this message]
2007-03-19 17:03 ` Josh Boyer
2007-03-19 17:21 ` Joakim Tjernlund
2007-03-19 17:35 ` Josh Boyer
2007-03-19 18:17 ` Joakim Tjernlund
2007-03-19 18:53 ` Josh Boyer
2007-03-19 19:04 ` MikeW
2007-03-22 12:42 ` Joakim Tjernlund
2007-03-19 18:23 ` MikeW
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20070319T174627-836@post.gmane.org \
--to=mw_phil@yahoo.co.uk \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox