When to use mtd.h or mtd-user.h

When to use mtd.h or mtd-user.h

[MikeW]

I note some applications for running in userspace say:
#include <linux/mtd/mtd.h>
and some say
#include <mtd/mtd-user.h>

Which is the recommended usage, and why ?

Many thanks,
MikeW

Re: When to use mtd.h or mtd-user.h

[Josh Boyer]

On 5/15/07, MikeW <mw_phil@yahoo.co.uk> wrote:
> I note some applications for running in userspace say:
> #include <linux/mtd/mtd.h>

Er, which ones?  I don't see anything in mtd-utils that does that.

> and some say
> #include <mtd/mtd-user.h>
>
> Which is the recommended usage, and why ?

mtd-user.h because it's been sanitized for inclusion in userspace.

josh

Re: When to use mtd.h or mtd-user.h

[Robert P. J. Day]

On Tue, 15 May 2007, MikeW wrote:

> I note some applications for running in userspace say:
> #include <linux/mtd/mtd.h>
> and some say
> #include <mtd/mtd-user.h>
>
> Which is the recommended usage, and why ?

i'm not even sure where that first header file would be coming from.
it's not part of glibc, and it's not created as part of the sanitized
headers by the kernel.  are you sure you've seen that in someone's
*userspace* code?  and the inclusion worked?

in any event, it's that second header file that's correct.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: When to use mtd.h or mtd-user.h

[MikeW]

Robert P. J. Day <rpjday <at> mindspring.com> writes:

> 
> 
> i'm not even sure where that first header file would be coming from.
> it's not part of glibc, and it's not created as part of the sanitized
> headers by the kernel.  are you sure you've seen that in someone's
> *userspace* code?  and the inclusion worked?
> 
> in any event, it's that second header file that's correct.
> 
> rday

The line #include <linux/mtd/mtd.h> is taken from uboot/tools/env/fw_env.c
from www.denx.de (v.1.1.4)

There's another usage in openwrt/package/mtd/mtd.c

Both are intended to run as userspace apps.
However, making the mtd-user.h patch allows them to build without complaint.

Thanks,
MikeW

Re: When to use mtd.h or mtd-user.h

[MikeW]

MikeW <mw_phil <at> yahoo.co.uk> writes:

> 
> I note some applications for running in userspace say:
> #include <linux/mtd/mtd.h>
> and some say
> #include <mtd/mtd-user.h>
> 
> Which is the recommended usage, and why ?
> 
> Many thanks,
> MikeW

Incidentally, I did actually realise which was the *correct* usage,
but I wondered why anyone (especially uBoot) would use the other.

Thanks for the comments,
MikeW

Re: When to use mtd.h or mtd-user.h

[Artem Bityutskiy]

On Wed, 2007-05-16 at 09:54 +0000, MikeW wrote:
> Incidentally, I did actually realise which was the *correct* usage,
> but I wondered why anyone (especially uBoot) would use the other.

Because most people send questions but not patches :-) ?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

Re: When to use mtd.h or mtd-user.h

[MikeW]

Artem Bityutskiy <dedekind <at> infradead.org> writes:

> 
> On Wed, 2007-05-16 at 09:54 +0000, MikeW wrote:
> > Incidentally, I did actually realise which was the *correct* usage,
> > but I wondered why anyone (especially uBoot) would use the other.
> 
> Because most people send questions but not patches  ?
> 

Trouble is, the people with the questions do not usually consider
themselves authoritative enough to send in a patch, since they
feel (possibly correctly!) that they do not know the system
well enough to be aware of implications of what on the face of
it might be a simple 'correction'.

In which case, those who *are* authoritative may, if they have the
time and inclination, pick up on the issue and make the correction!

But I would submit patches if I felt sufficiently knowledgeable
in the relevant area of code.

Regards,
MikeW (мАйк)

Re: When to use mtd.h or mtd-user.h

[Artem Bityutskiy]

On Wed, 2007-05-16 at 10:34 +0000, MikeW wrote:
> In which case, those who *are* authoritative may, if they have the
> time and inclination, pick up on the issue and make the correction!

But now when you know which header is correct, you could send a patch to
uBoot. Also, when you got some answers to some questions, you could send
a patch against mtd-www.git and add a FAQ entry. And so on. :-)

> Regards,
> MikeW (мАйк)
:-) МайкВ

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

Re: When to use mtd.h or mtd-user.h

[Wolfgang Denk]

In message <loom.20070515T170629-855@post.gmane.org> you wrote:
> I note some applications for running in userspace say:
> #include <linux/mtd/mtd.h>
> and some say
> #include <mtd/mtd-user.h>
> 
> Which is the recommended usage, and why ?

<linux/mtd/mtd.h> used to be used on very old (2.4) kernel versions;
<mtd/mtd-user.h> has to be used now.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The biggest difference between time and space is that you can't reuse
time.                                                 - Merrick Furst