From: MikeW <mw_phil@yahoo.co.uk>
To: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Fix kfree usage in various mtd map remove functions
Date: Mon, 21 May 2007 15:44:28 +0000 (UTC) [thread overview]
Message-ID: <loom.20070521T174147-996@post.gmane.org> (raw)
In-Reply-To: 1179425894742@dmwebmail.belize.chezphil.org
Phil Endecott <spam_from_linux_mtd <at> chezphil.org> writes:
>
> The remove() functions in various mtd map drivers were incorrectly kfree()ing
the struct
> resource that they had passed to release_resource(), and/or failing to free
the *_flash_info
> structure. This looks like a typo which has gradually propogated by
copy&paste into a number
> of these drivers.
>
> Since mtd drivers are rarely or never used as modules (they typically provide
root filesystems)
> it is unlikely that these code paths have ever been exercised. It also means
that this patch
> has not been tested by the author.
>
> This patch is against 2.6.21.
>
> Signed-off-by: Phil Endecott <spam_from_linux_mtd_patch <at> chezphil.org>
>
Good chap !!
They could be tested by building as modules then insmod/rmmod-ing
repeatedly, whilst observing kernel memory usage, before and after fix.
Regards,
MikeW
next prev parent reply other threads:[~2007-05-21 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 18:18 [PATCH] Fix kfree usage in various mtd map remove functions Phil Endecott
2007-05-21 15:44 ` MikeW [this message]
2007-05-21 17:09 ` Phil Endecott
2007-05-23 8:01 ` MikeW
2007-05-21 15:53 ` MikeW
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20070521T174147-996@post.gmane.org \
--to=mw_phil@yahoo.co.uk \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox