Re: [PATCH] basic pxa3 nand controller support

[Marcel Ziswiler <marcel@ziswiler.com>]

eric miao <eric.y.miao <at> gmail.com> writes:

> Early feedback is welcome, thanks!

Hi Eric

Overall the patch looks good, just a few comments.

The patch does not apply cleanly unless I remove the spurious newline before
line 1284 resulting in the following error:
patch: **** malformed patch at line 1284: pm_message_t state)

The DRCMR97 register is not defined anywhere, at lest not in 2.6.24-rc6:
drivers/mtd/nand/pxa3xx_nand.c:542: error: ‘DRCMR97’ undeclared (first use in
this function)

The registers and bit definitions should be moved to pxa-regs.h, not?

I had my troubles getting it to work on a custom PXA320 board. I kinda figured
out what platform data it needs, but still can't seem to get it to work properly:
pxa3xx-nand pxa3xx-nand: failed to detect flash

What kernel does your patch apply to? What CPUs/boards did you try it on? Can
you provide an example platform integration required to make it work?

Cheers

Marcel