From: Christopher Moore <moore@free.fr>
To: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/4] [MTD] remove bogus warning about missing boot bank location
Date: Sun, 19 Oct 2008 05:33:37 +0000 (UTC) [thread overview]
Message-ID: <loom.20081019T051651-843@post.gmane.org> (raw)
In-Reply-To: 1216712341-25869-2-git-send-email-Uwe.Kleine-Koenig@digi.com
Uwe Kleine-König <Uwe.Kleine-Koenig <at> digi.com> writes:
>
> After the deleted block bootloc is only used once as follows:
>
> if (bootloc == 3 && something_else) {
> ...
>
> So setting bootloc = 2 doesn't change anything. Taking that the warning is
> wrong and missleading.
>
> Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig <at> digi.com>
Nice catch, Uwe.
IMHO the worst thing is that the warning is completely bogus.
It says "Assuming top" but the next line sets bootloc to bottom (2) :(
See also this thread: http://thread.gmane.org/gmane.linux.drivers.mtd/22176
Last time I looked this patch had not been applied so I am pinging it.
Therefore a bit late and FWIW:-
Acked-by: Christopher Moore <moore@free.fr>
prev parent reply other threads:[~2008-10-19 5:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 7:38 [PATCH 0/4] some mtd fixes Uwe Kleine-König
2008-07-22 7:38 ` [PATCH 1/4] [MTD] remove bogus warning about missing boot bank location Uwe Kleine-König
2008-07-22 7:38 ` [PATCH 2/4] [RFC] [MTD] cfi_probe: remove Intel chip workaround Uwe Kleine-König
2008-07-22 7:39 ` [PATCH 3/4] [MTD] physmap: Fix suspend/resume/shutdown bugs Uwe Kleine-König
2008-07-22 7:39 ` [PATCH 4/4] [MTD] physmap: resume already suspended chips on failure to suspend Uwe Kleine-König
2008-07-25 13:52 ` [PATCH 2/4] [RFC] [MTD] cfi_probe: remove Intel chip workaround David Woodhouse
2008-07-25 20:45 ` Uwe Kleine-König
2008-07-28 7:21 ` Alexander Belyakov
2008-07-28 14:05 ` Alexey Korolev
2008-08-05 14:41 ` Alexey Korolev
2008-10-19 5:33 ` Christopher Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20081019T051651-843@post.gmane.org \
--to=moore@free.fr \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox