public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: linux-mtd@lists.infradead.org
Subject: Re: [RFC] Handling of errors for AMD NOR (cfi_cmdset_0002) chips
Date: Wed, 23 Mar 2011 18:27:48 +0000 (UTC)	[thread overview]
Message-ID: <loom.20110323T192107-666@post.gmane.org> (raw)
In-Reply-To: 4D7F1CF3.5010301@tqsc.de

Hello Markus,

Markus Niebel <list-09_linux_mtd <at> tqsc.de> writes:
> what type of chips are causing your problems?

As Detlev has already wrote they are 16-bit Spansion S29GL512P.

> AFAIK in cfi_cmdset_0002 the use of max timouts from cfi query struct is 
> missing (support in the per chip struct is prepared). This should be 
> done first (I think).

Hm, I have to admit I'm not really a flash expert. Could you please give me some
pointer?

> Regarding the handling of status bits you can use MERGESTATUS / 
> cfi_merge_status (from linux/mtd/cfi.h)

Well, most of my code is actually stolen from cfi_merge_status implementation.
Still, I think it's incorrect to use MERGESTATUS directly: we need to filter
that have already finished (with no toggling bits), otherwise we can take the
data byte as a status.

> Would it be useful to send rough patches for 2.6.34 for the max timout?

Yes, please do post them. Any information would be useful.

Regards, Ilya.

  parent reply	other threads:[~2011-03-23 18:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11  1:42 [RFC] Handling of errors for AMD NOR (cfi_cmdset_0002) chips Ilya Yanok
2011-03-11  8:25 ` Norbert van Bolhuis
2011-03-23 15:47   ` Detlev Zundel
2011-03-23 17:33     ` Artem Bityutskiy
2011-03-24  7:35     ` Norbert van Bolhuis
2011-03-24  9:27       ` Detlev Zundel
2011-03-24 10:48         ` Norbert van Bolhuis
2011-03-15  8:01 ` Markus Niebel
2011-03-23 16:16   ` Detlev Zundel
2011-03-23 18:27   ` Ilya Yanok [this message]
2011-03-24  7:45 ` Alexander Stein
2011-03-24  7:55   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20110323T192107-666@post.gmane.org \
    --to=yanok@emcraft.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox