From: ebiederman@lnxi.com (Eric W. Biederman)
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: JFFS2 with AM29LV256M
Date: 19 Aug 2004 04:45:48 -0600 [thread overview]
Message-ID: <m33c2j76eb.fsf@maxwell.lnxi.com> (raw)
In-Reply-To: <1092910597.14552.1683.camel@hades.cambridge.redhat.com>
David Woodhouse <dwmw2@infradead.org> writes:
> On Thu, 2004-08-19 at 11:40 +0200, Manfred Gruber wrote:
> > Am Donnerstag, 19. August 2004 10:32 schrieben Sie:
> >
> > > Our code which should handle suspending erases to allow programming is
> > > broken. So we disabled it -- you have to wait for erases to complete
> > > before the code will write data to the flash instead.
> >
> > Then i have to change the do_write_oneword function to wait until erase is
> > finshed ?
>
> No, we did that already. And we put that printk in to remind us to fix
> it properly some time soon.
When you get to that please make certain the code is disabled for
chips coming from jedec_probe as by and large they don't support erase
suspend. I was wondering why there was a print statement in there with
no code connected to it.
> > the difference is: cp rootfs.img /dev/mtd only uses:
> >
> > MTD_write
> > MTD_do_write_buffer
> > and so on ...
> >
> > and cp a file on the mounted image uses:
> >
> > MTD do_write_buffer(): WRITE 0x0028641c(0xe0011985)
> > MTD do_write_oneword(): WRITE 0x0028641c(0xd5997a45)
> > MTD do_write_oneword(): software timeout
>
> Hmmm ok, so it's do_write_oneword() which is broken.
Possibly it still could be the chip. do_write_oneword since it
is read the data back anyway confirms that the data read back is
what was written. I don't believe the write_buffer code path
does any but the most rudimentary sanity checks.
Eric
next prev parent reply other threads:[~2004-08-19 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-19 8:06 JFFS2 with AM29LV256M Manfred Gruber
2004-08-19 8:32 ` David Woodhouse
2004-08-19 9:40 ` Manfred Gruber
2004-08-19 10:16 ` David Woodhouse
2004-08-19 10:45 ` Eric W. Biederman [this message]
2004-08-19 12:30 ` Manfred Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33c2j76eb.fsf@maxwell.lnxi.com \
--to=ebiederman@lnxi.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox