From: ebiederman@lnxi.com (Eric W. Biederman)
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [RFC] refactoring MTD cmdset ops, jedec_probe, and cfi_probe
Date: 13 Jul 2004 08:23:46 -0600 [thread overview]
Message-ID: <m3u0wcj899.fsf@maxwell.lnxi.com> (raw)
In-Reply-To: <1089705743.2899.46.camel@hades.cambridge.redhat.com>
David Woodhouse <dwmw2@infradead.org> writes:
> On Tue, 2004-07-13 at 01:05 -0600, Eric W. Biederman wrote:
> > That part does not look to bad...
>
> Would be interesting to know if it works though ... :)
>
> > Although there has been some error handling from cfi_cmdset_0002.c which
> > disturbs me. Seeing as I'm good at finding flaky NOR flash parts...
>
> I assume you mean some error handling _removed_ from cfi_cmdset_0002.c
>
> I don't recall doing that myself... can you elaborate?
Right. Basically when Thayne was working on cfi_cmdset_0002 we got it stable
for the chips we care about. But the code was so ugly someone rewrote the
code. There were other priorities at the time so we have not been able to
get back and fix things up.
The primary thing was that the check that the written data is was what
we actually tried to write was removed.
> > That time line is a bit challenging. My safe guess was about a week to get
> > everything written and tested...
>
> Yeah, that seems reasonable. I'll sync to Linus this week anyway, then I
> can do it again in August when I get back and the dust has settled on
> your changes.
Sounds sane.
Eric
next prev parent reply other threads:[~2004-07-13 14:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 3:13 [RFC] refactoring MTD cmdset ops, jedec_probe, and cfi_probe Eric W. Biederman
2004-07-13 6:25 ` David Woodhouse
2004-07-13 7:05 ` Eric W. Biederman
2004-07-13 8:02 ` David Woodhouse
2004-07-13 14:23 ` Eric W. Biederman [this message]
2004-07-13 14:45 ` Thayne Harbaugh
2004-07-13 15:04 ` Eric W. Biederman
2004-07-13 15:21 ` Thayne Harbaugh
2004-07-13 15:40 ` Eric W. Biederman
2004-07-13 16:00 ` Eric W. Biederman
2004-07-14 5:44 ` Eric W. Biederman
2004-08-12 7:39 ` Eric W. Biederman
2004-07-13 15:25 ` Eric W. Biederman
2004-07-13 16:17 ` Josh Boyer
2004-08-12 7:13 ` Eric W. Biederman
2004-08-16 14:13 ` Josh Boyer
2004-07-13 16:36 ` Dan Post
2004-07-13 16:52 ` Nicolas Pitre
2004-07-13 17:33 ` Dan Post
2004-07-13 18:17 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3u0wcj899.fsf@maxwell.lnxi.com \
--to=ebiederman@lnxi.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox