Re: [RFC] refactoring MTD cmdset ops, jedec_probe, and cfi_probe

[ebiederman@lnxi.com (Eric W. Biederman)]

Thayne Harbaugh <tharbaugh@lnxi.com> writes:

> On Tue, 2004-07-13 at 09:04 -0600, Eric W. Biederman wrote:
> > Thayne Harbaugh <tharbaugh@lnxi.com> writes:
> 
> > > There's a short list of things that have been removed or changed
> > > significantly (although this is from memory and may not match the
> > > current code):
> > > 
> > > * read-back check of written data
> > 
> > I have a patch  for that already.  Since we are not checking any other
> > status bits.  At least verifying the data is correct is useful.  
> 
> Wonderful.
> 
> > > * retry of failed writes
> > 
> > This one is more interesting.  I don't know if it should be generic or we
> should
> 
> > just override do_write_one_word...
> > 
> > One way or another we will get this one back in there.
> 
> Good.

Looking at where we are Dave has just reworked the code for handling multiple
word sizes for reads and writes, and things are just starting to settle out.
And since he is going to be gone he will be sending these changes to Linus
later this week.

Since refactoring does not work well if I don't have a working code base
to start with. I will push for the appropriate fixes to the MTD command sets
so I know I am starting with a working base.  And then I will start refactoring
the command sets.

Eric