From: ebiederman@lnxi.com (Eric W. Biederman)
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c
Date: Tue, 08 Nov 2005 11:10:27 -0700 [thread overview]
Message-ID: <m3zmofovsc.fsf@maxwell.lnxi.com> (raw)
In-Reply-To: <20051108105923.GA31446@wohnheim.fh-wedel.de> ( Jörn Engel's message of "Tue, 8 Nov 2005 11:59:24 +0100")
Jörn Engel <joern@wohnheim.fh-wedel.de> writes:
> Moving crap over to mtdchar.c is a good thing. Complete removal of
> mtdchar.c might be even better, but at least the crap is relatively
> self-contained now.
Agreed moving the compat_ioctl to mtdchar now that it is possible
sounds good.
I can see that argument with respect to mtdblock. But why would
removal of mtdchar be a good thing? It is a simple raw access
interface. For those whose flash parts are too small for a filesystem
or when you are doing things that you can't do with a filesystem
like making or checking it you need something like mtd char. For
embedded folks who don't care you can just compile it out.
Eric
next prev parent reply other threads:[~2005-11-08 18:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-05 16:26 [PATCH 00/25] reduce code in fs/compat_ioctl.c Arnd Bergmann
2005-11-05 16:26 ` [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c Arnd Bergmann
2005-11-08 10:59 ` Jörn Engel
2005-11-08 18:10 ` Eric W. Biederman [this message]
2005-11-08 18:33 ` Jörn Engel
2005-11-08 18:45 ` Josh Boyer
2005-11-08 18:57 ` Thomas Gleixner
2005-11-08 22:21 ` Jörn Engel
2005-11-09 0:04 ` Thomas Gleixner
2005-11-08 19:03 ` David Woodhouse
2005-11-09 15:37 ` Eric W. Biederman
2005-11-09 15:48 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zmofovsc.fsf@maxwell.lnxi.com \
--to=ebiederman@lnxi.com \
--cc=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox