From: Pratyush Yadav <pratyush@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
<linux-mtd@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] spi: spi-mem: Add missing kdoc argument
Date: Mon, 04 Aug 2025 16:45:47 +0200 [thread overview]
Message-ID: <mafs0ms8fcfhg.fsf@kernel.org> (raw)
In-Reply-To: <20250804095013.409700-1-miquel.raynal@bootlin.com>
On Mon, Aug 04 2025, Miquel Raynal wrote:
> The "*mem" pointer has been added without description, describe it in
> the kdoc comment in order to fix the following W=1 warning:
Hmm, this warning does not show up for me with W=1, but does with W=2. I
am running:
make drivers/spi/spi-mem.o LLVM=1 ARCH=arm W=1
Am I doing something wrong? I usually test with W=1 for SPI NOR patches
to make sure no new warnings are added.
Anyway,
Acked-by: Pratyush Yadav <pratyush@kernel.org>
>
> Warning: drivers/spi/spi-mem.c:594 function parameter 'mem' not
> described in 'spi_mem_calc_op_duration'
>
> Fixes: a11a51896572 ("spi: spi-mem: Take into account the actual maximum frequency")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507310409.fnuQ21qb-lkp@intel.com/
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> drivers/spi/spi-mem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
> index d3b7e857b377..841b0995c8ea 100644
> --- a/drivers/spi/spi-mem.c
> +++ b/drivers/spi/spi-mem.c
> @@ -577,6 +577,7 @@ EXPORT_SYMBOL_GPL(spi_mem_adjust_op_freq);
> * spi_mem_calc_op_duration() - Derives the theoretical length (in ns) of an
> * operation. This helps finding the best variant
> * among a list of possible choices.
> + * @mem: the SPI memory
> * @op: the operation to benchmark
> *
> * Some chips have per-op frequency limitations, PCBs usually have their own
--
Regards,
Pratyush Yadav
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-08-04 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 9:50 [PATCH] spi: spi-mem: Add missing kdoc argument Miquel Raynal
2025-08-04 14:45 ` Pratyush Yadav [this message]
2025-08-05 7:43 ` Miquel Raynal
2025-08-06 12:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs0ms8fcfhg.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).