From: Pratyush Yadav <pratyush@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Luke Wang <ziniu.wang_1@nxp.com>,
"pratyush@kernel.org" <pratyush@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"michael@walle.cc" <michael@walle.cc>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"p.yadav@ti.com" <p.yadav@ti.com>,
"richard@nod.at" <richard@nod.at>,
"vigneshr@ti.com" <vigneshr@ti.com>,
Bough Chen <haibo.chen@nxp.com>, Han Xu <han.xu@nxp.com>
Subject: Re: [PATCH v2 6/6] mtd: spi-nor: core: avoid odd length/address writes in 8D-8D-8D mode
Date: Wed, 07 May 2025 09:43:25 +0000 [thread overview]
Message-ID: <mafs0zffo3gea.fsf@kernel.org> (raw)
In-Reply-To: <10b40148-b949-442d-9d43-0db09517269a@linaro.org>
Hi Luke,
On Tue, Apr 29 2025, Tudor Ambarus wrote:
> On 4/29/25 10:03 AM, Luke Wang wrote:
>> Hi Pratyush,
>>
>> I'm following up on this patch series [1] Avoid odd length/address read/
>> writes in 8D-8D-8D mode. While some of the series has been merged, the
>> patch 4-6 remains unmerged.
>>
>> In fact, we also encountered similar read/write issue of odd address/
>> length with NXP FSPI controller (spi-nxp-fspi.c). Currently, we handled
>> the odd address/length in the controller driver, but I think this should
>> be a common issue in the octal dtr mode. Was there a technical reason
>> for not merging the core layer solution?
>
> I guess I stumbled on those small comments and did not consider the
> greater benefit of taking the patches. No one cared and we forgot about
> it. Please address the comments and resubmit.
Yes, it should have been a simple next revision from me but apparently
it fell through the cracks. I do strongly agree that this should be done
in SPI NOR, and not in controller drivers. So it would be great if you
can respin the remaining patches of the series.
--
Regards,
Pratyush Yadav
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-05-07 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DU2PR04MB85678048FE8B475B1E323E0AED802@DU2PR04MB8567.eurprd04.prod.outlook.com>
2025-04-29 9:22 ` [PATCH v2 6/6] mtd: spi-nor: core: avoid odd length/address writes in 8D-8D-8D mode Tudor Ambarus
2025-05-07 9:43 ` Pratyush Yadav [this message]
2025-05-12 7:57 ` Miquel Raynal
2025-05-12 8:33 ` Bough Chen
2025-05-12 9:34 ` Pratyush Yadav
2025-05-12 11:09 ` Bough Chen
2025-07-01 7:47 ` Luke Wang
2025-07-24 14:14 ` Pratyush Yadav
2021-05-31 18:17 [PATCH v2 0/6] Avoid odd length/address read/writes " Pratyush Yadav
2021-05-31 18:17 ` [PATCH v2 6/6] mtd: spi-nor: core: avoid odd length/address writes " Pratyush Yadav
2021-06-01 12:44 ` Michael Walle
2021-12-23 12:59 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs0zffo3gea.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=broonie@kernel.org \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
--cc=ziniu.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).