From: sashiko-bot@kernel.org
To: "Matthew Parker" <mparker@arista.com>,
pratyush@kernel.org, mwalle@kernel.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com
Cc: linux-mtd@lists.infradead.org, "Adam Calabrigo" <adamc@arista.com>
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for ISSI IS25LP512MG
Date: Sun, 08 Nov 2026 00:53:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-203508@kernel.org> (raw)
In-Reply-To: <20261108004516.896887-1-mparker@arista.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] mtd: spi-nor: issi: build failure from removed parse_sfdp
initializer
- [Medium] mtd: spi-nor: issi: setting .size and .name breaks
spi_nor_needs_sfdp()
--
commit b81da267d9946b2790b1da232d5027f7a818531c
Author: Matthew Parker <mparker@arista.com>
mtd: spi-nor: issi: Add support for ISSI IS25LP512MG
This commit adds a flash_info entry for the ISSI IS25LP512MG 64 MiB SPI NOR
flash in issi_nor_parts[].
> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
> index 2f057d731df2a..977dc5ba80289 100644
> --- a/drivers/mtd/spi-nor/issi.c
> +++ b/drivers/mtd/spi-nor/issi.c
> @@ -101,6 +101,12 @@ static const struct flash_info issi_nor_parts[] = {
> }, {
> .id = SNOR_ID(0x9d, 0x60, 0x19),
> .name = "is25lp256",
> + }, {
> + .id = SNOR_ID(0x9d, 0x60, 0x20),
> + .name = "is25lp512mg",
> + .size = SZ_64M,
[Severity: Medium]
Does setting .size = SZ_64M break spi_nor_needs_sfdp() for this flash?
spi_nor_needs_sfdp() returns !nor->info->size, so setting .size causes
spi_nor_init_params() to ignore spi_nor_parse_sfdp() failures and fall back
to incomplete parameters without 4 KiB erase or fast-read modes. In
addition, struct flash_info documents .name as obsolete for new SFDP-based
entries; both .size and .name should be omitted here.
> + .flags = SPI_NOR_QUAD_PP,
> + .parse_sfdp = true,
[Severity: High]
Does this fail to build when CONFIG_MTD_SPI_NOR is enabled? struct
flash_info has no .parse_sfdp member since 3ea3f0ac242c ("mtd: spi-nor:
drop .parse_sfdp").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261108004516.896887-1-mparker@arista.com?part=1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2026-11-08 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 0:45 [PATCH] mtd: spi-nor: issi: Add support for ISSI IS25LP512MG Matthew Parker
2026-11-08 0:53 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203508@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=adamc@arista.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mparker@arista.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox