From: sashiko-bot@kernel.org
To: "Matthew Parker" <mparker@arista.com>,
pratyush@kernel.org, mwalle@kernel.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com
Cc: linux-mtd@lists.infradead.org, "Adam Calabrigo" <adamc@arista.com>
Subject: Re: [PATCH] mtd: spi-nor: gigadevice: Add support for GigaDevice GD25B512
Date: Sun, 08 Nov 2026 02:28:51 +0000 [thread overview]
Message-ID: <sashiko-outbox-203520@kernel.org> (raw)
In-Reply-To: <20261108022011.898185-1-mparker@arista.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] mtd: spi-nor: gigadevice: invalid .fixup_flags initializer in
flash_info
--
commit ff73c2eea3b59a78f4c9acc05bbd14cc3fb22bf2
Author: Matthew Parker <mparker@arista.com>
mtd: spi-nor: gigadevice: Add support for GigaDevice GD25B512
This commit adds a flash_info entry for the GigaDevice GD25B512 64 MiB SPI
NOR flash to gigadevice_nor_parts[].
> diff --git a/drivers/mtd/spi-nor/gigadevice.c b/drivers/mtd/spi-nor/gigadevice.c
> index 6a2e6ebda1483..de96cefde516b 100644
> --- a/drivers/mtd/spi-nor/gigadevice.c
> +++ b/drivers/mtd/spi-nor/gigadevice.c
> @@ -64,6 +64,10 @@ static const struct flash_info gigadevice_nor_parts[] = {
> .id = SNOR_ID(0xc8, 0x40, 0x19),
> .name = "gd25q256",
> .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6,
> + }, {
> + .id = SNOR_ID(0xc8, 0x47, 0x1a),
> + .flags = SPI_NOR_HAS_LOCK,
> + .fixup_flags = SPI_NOR_4B_OPCODES,
[Severity: High]
Does this break the build when CONFIG_MTD_SPI_NOR is enabled? struct
flash_info has no .fixup_flags member (fixup_flags lives in struct
spi_nor_fixup). Since the chip exposes an SFDP 4-byte Address Instruction
Table, spi_nor_parse_4bait() already sets SNOR_F_4B_OPCODES, so the
.fixup_flags initializer can be dropped.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261108022011.898185-1-mparker@arista.com?part=1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-11-08 2:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 2:20 [PATCH] mtd: spi-nor: gigadevice: Add support for GigaDevice GD25B512 Matthew Parker
2026-11-08 2:28 ` sashiko-bot [this message]
2026-11-09 8:51 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203520@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=adamc@arista.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mparker@arista.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox