Re: [PATCH v2 21/58] mtd: rawnand: fsl_upm: retain open-handle state on removal - sashiko-bot

From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 21/58] mtd: rawnand: fsl_upm: retain open-handle state on removal
Date: Tue, 10 Nov 2026 08:22:52 +0000	[thread overview]
Message-ID: <sashiko-outbox-206600@kernel.org> (raw)
In-Reply-To: <20261110-submit-rawnand-retained-handle-lifetime-v1-v2-21-9137d08f05df@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mtd: rawnand: fsl_upm: missing Fixes trailer for lifetime and
  cleanup bugs
--

commit 2c7c42fd4c06b5edc5eccea15db525bf72aef919
Author: James Hilliard <james.hilliard1@gmail.com>

> mtd: rawnand: fsl_upm: retain open-handle state on removal
>
> Keep chip metadata and controller storage alive until the final MTD
> reference is released. Unregister and disconnect each published chip
> before releasing the resources used by its hardware operations.
>
> Also clean up scanned chips when partition registration fails.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

[Severity: Low]
Since this fixes freeing the chip and controller state on removal while MTD
handles remain open and leaking scanned chip allocations when
mtd_device_register() fails in fun_chip_init(), should it include a Fixes
tag?

  Fixes: 5c249c5a57dc ("[MTD] [NAND] FSL UPM NAND driver")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-submit-rawnand-retained-handle-lifetime-v1-v2-0-9137d08f05df@gmail.com?part=21

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/