Re: [PATCH v4 27/58] mtd: rawnand: technologic: retain open-handle state on removal - sashiko-bot

From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v4 27/58] mtd: rawnand: technologic: retain open-handle state on removal
Date: Fri, 13 Nov 2026 18:39:37 +0000	[thread overview]
Message-ID: <sashiko-outbox-213417@kernel.org> (raw)
In-Reply-To: <20261113-submit-rawnand-retained-handle-lifetime-v1-v4-27-556b1d7c6221@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mtd: rawnand: technologic: missing Fixes trailer for commit
  853034c7d8c0
--

commit 9acd5b45a3e91e6446fb18eacd2c7b71b9346ba1
Author: James Hilliard <james.hilliard1@gmail.com>

> mtd: rawnand: technologic: retain open-handle state on removal
>
> Keep chip metadata and controller storage alive until the final MTD
> reference is released. Unregister and disconnect each published chip
> before releasing the resources used by its hardware operations.
>
> Transfer flash-node ownership to the retained-chip helper.
>
> Run NAND cleanup during disconnection; the final core-owned put only
> releases retained allocation and layout data.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

[Severity: Low]
This fixes the open-handle removal lifetime and unbalanced
fwnode_handle_put() in ts72xx_nand_remove() introduced with the driver.
Should this include:

  Fixes: 853034c7d8c0 ("mtd: rawnand: add support for ts72xx")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-submit-rawnand-retained-handle-lifetime-v1-v4-0-556b1d7c6221@gmail.com?part=27

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/