Re: [PATCH 07/12] docs: ioctl-number: update MTD entries - sashiko-bot

From: sashiko-bot@kernel.org
To: "Randy Dunlap" <rdunlap@infradead.org>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"David Hildenbrand" <david@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Jason Gunthorpe" <jgg@nvidia.com>,
	"Leon Romanovsky" <leonro@nvidia.com>,
	linux-mm@kvack.org, "Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	linux-sound@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>,
	"Marcel Holtmann" <marcel@holtmann.org>,
	"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
	"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
	"Jason Wang" <jasowangio@gmail.com>,
	"David Heidelberg" <david@ixit.cz>,
	"Chas Williams" <3chas3@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>, "Helge Deller" <deller@gmx.de>,
	dri-devel@lists.freedesktop.org,
	MPT-FusionLinux.pdl@broadcom.com,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <mkp@kernel.org>,
	linux-scsi@vger.kernel.org,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Zhihao Cheng" <chengzhihao1@huawei.com>,
	linux-mtd@lists.infradead.org,
	"Neill Kapron" <nkapron@google.com>,
	"Andrey Konovalov" <andreyknvl@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, "Juergen Gross" <jgross@suse.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Hans de Goede" <hansg@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Sean Christopherson" <seanjc@google.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	kvm@vger.kernel.org, virtualization@lists.linux.dev,
	"Jan Kara" <jack@suse.cz>, "Theodore Ts'o" <tytso@mit.edu>,
	linux-ext4@vger.kernel.org, "Mike Marshall" <hubcap@omnibond.com>,
	devel@lists.orangefs.org, "Paulo Alcantara" <pc@manguebit.org>,
	"Namjae Jeon" <linkinjeon@kernel.org>,
	"Jaegeuk Kim" <jaegeuk@kernel.org>, "Chao Yu" <chao@kernel.org>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Tzung-Bi Shih" <tzungbi@kernel.org>,
	"Benson Leung" <bleung@chromium.org>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	amd-gfx@lists.freedesktop.org,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	intel-gfx@lists.freedesktop.org,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 07/12] docs: ioctl-number: update MTD entries
Date: Sun, 15 Nov 2026 20:27:49 +0000	[thread overview]
Message-ID: <sashiko-outbox-215807@kernel.org> (raw)
In-Reply-To: <20261114202653.3113381-8-rdunlap@infradead.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] docs: ioctl-number: missing update of 'O' range for
  mtd/ubi-user.h to 00-08
--

commit ccf1b77b46484d55fbc7ee02d93a71ebab16f010
Author: Randy Dunlap <rdunlap@infradead.org>

docs: ioctl-number: update MTD entries

This commit updates the sequence number ranges and file entries for MTD
and UBI ioctls in Documentation/userspace-api/ioctl/ioctl-number.rst.

> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index d47f817335666..1ff4fd4bf9b5c 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst

[ ... ]

> @@ -306,7 +306,7 @@ Code  Seq#    Include File                                             Comments
>  'n'   E0-FF  linux/matroxfb.h                                          matroxfb
>  'n'   F8-FA  video/sisfb.h                                             sisfb
>  'o'   00-1F  fs/ocfs2/ocfs2_fs.h                                       OCFS2
> -'o'   00-03  mtd/ubi-user.h                                            conflict! (OCFS2 and UBI overlaps)
> +'o'   00-06  mtd/ubi-user.h                                            conflict! (OCFS2 and UBI overlap)

[Severity: Low]
Should the 'O' entry for mtd/ubi-user.h also be updated from 00-06 to
00-08?  include/uapi/mtd/ubi-user.h defines UBI_VOL_IOC_MAGIC ('O')
ioctls up to 8 (UBI_IOCVOLCRBLK at 7 and UBI_IOCVOLRMBLK at 8).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114202653.3113381-1-rdunlap@infradead.org?part=7

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/