Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>,
	"Srinivas Kandagatla" <srini@kernel.org>,
	"Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>,
	"Michael Walle" <mwalle@kernel.org>,
	"Rafał Miłecki" <rafal@milecki.pl>
Cc: "Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Paul Cercueil" <paul@crapouillou.net>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 02/11] nvmem: drain keepout and cell post-processing accesses
Date: Tue, 17 Nov 2026 19:50:06 +0000	[thread overview]
Message-ID: <sashiko-outbox-219526@kernel.org> (raw)
In-Reply-To: <20261117-submit-nvmem-provider-lifetime-v1-v1-2-3cfbd48812b5@gmail.com>

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Critical] nvmem: core: race condition in __nvmem_reg_write() during
  WP GPIO toggling [1]
--

commit 1a5a4f5f38aeaf6b1486ab8a21e16285a6795aae
Author: James Hilliard <james.hilliard1@gmail.com>

nvmem: drain keepout and cell post-processing accesses

This commit extends SRCU read-lock protection and nvmem->ops validation to
cover keepout region handling in nvmem_reg_read() and nvmem_reg_write() as
well as cell post-processing in __nvmem_cell_read().

> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 802637f375f8b..73aa53145f0b7 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c

[ ... ]

> @@ -173,6 +177,10 @@ static int nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset,
>  static int nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offset,
>  			   void *val, size_t bytes)
>  {
> +	guard(srcu)(&nvmem->srcu);
> +	if (!srcu_dereference(nvmem->ops, &nvmem->srcu))
> +		return -ENODEV;
> +
>  	if (!nvmem->nkeepout)
>  		return __nvmem_reg_write(nvmem, offset, val, bytes);

[Severity: Critical]
This problem wasn't introduced by this patch, but can concurrent callers of
__nvmem_reg_write() race on nvmem->wp_gpio [1]?

drivers/nvmem/core.c:__nvmem_reg_write() {
	...
	ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 0);
	if (ret)
		return ret;

	wr_ok = ops->reg_write(nvmem->priv, offset, val, bytes);

	ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 1);
	...
}

Nothing serializes the write-protect GPIO transitions across concurrent
writes:

CPU0                                  CPU1
__nvmem_reg_write()                   __nvmem_reg_write()
  gpiod_set_value_cansleep(wp, 0)
                                        gpiod_set_value_cansleep(wp, 0)
  ops->reg_write(...)
  gpiod_set_value_cansleep(wp, 1)
                                        ops->reg_write(...)  <-- WP active

CPU0 re-asserts write protection while CPU1 is still executing
ops->reg_write(), which can cause dropped writes, hardware errors, or
silent data corruption.

[1] https://sashiko.dev/#/bug/linux-d7d845df-786a-40cf-b43c-f4ce2e295c82

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-submit-nvmem-provider-lifetime-v1-v1-0-3cfbd48812b5@gmail.com?part=2

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-11-17 19:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 19:38 [PATCH 00/11] nvmem: complete provider and layout disconnection James Hilliard
2026-11-17 19:38 ` [PATCH 01/11] nvmem: retain the provider node until device release James Hilliard
2026-11-17 19:38 ` [PATCH 02/11] nvmem: drain keepout and cell post-processing accesses James Hilliard
2026-11-17 19:50   ` sashiko-bot [this message]
2026-11-17 19:38 ` [PATCH 03/11] nvmem: exclude disconnected providers from callback admission James Hilliard
2026-11-17 19:38 ` [PATCH 04/11] nvmem: release write protection when the provider disconnects James Hilliard
2026-11-17 19:38 ` [PATCH 05/11] nvmem: reference cell entries independently of their provider list James Hilliard
2026-11-17 19:48   ` sashiko-bot
2026-11-17 19:38 ` [PATCH 06/11] nvmem: manage cell attributes independently of device resources James Hilliard
2026-11-17 19:59   ` sashiko-bot
2026-11-17 19:38 ` [PATCH 07/11] nvmem: distinguish layout cells from provider cells James Hilliard
2026-11-17 19:51   ` sashiko-bot
2026-11-17 19:38 ` [PATCH 08/11] nvmem: disconnect cells before removing their layout James Hilliard
2026-11-17 19:38 ` [PATCH 09/11] nvmem: disconnect published devices before registration rollback James Hilliard
2026-11-17 19:38 ` [PATCH 10/11] nvmem: u-boot-env: propagate cell registration errors James Hilliard
2026-11-17 19:38 ` [PATCH 11/11] nvmem: allow providers to specify an explicit NULL owner James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219526@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.hilliard1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=paul@crapouillou.net \
    --cc=rafal@milecki.pl \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=srini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox