From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58608EB64DA for ; Wed, 19 Jul 2023 05:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XKglwpR8O4912bz+RZUdOzzvoe7u/Y46ng2qsCSpH7U=; b=RLIbwgg0M1O0Q9 tvjus1U0Bu18z04PfFmGXfNISby+4KTtRDZpYUNNreB6oICKtAigRp2Q26KKHTjo3AbtcuhkVON7s YZefGVWIytTj0bc7iC/rPBj+z+qstraTG13lJJt+yfZElZpK9Ik7OC9xlnreXWFm4wunCKkvduIu+ 7SG3zGpIpCCWSxTHy/ixFfa9Thd8DuAneQ1xuKaeVHi2c9wD45rTisdTG+RGZ36fnSwA7RV+DTihR ux2W9bO4sV+x3PhLQiNV4dFE1SAtIXzzMxl4YFREFBn8nuc0jKr3uucAP/9VuNgC0ko+1elcqnbJl Aj4Fzz13Qn36485LmPzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM08B-005S0Y-0J; Wed, 19 Jul 2023 05:53:47 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM089-005RzN-26 for linux-mtd@bombadil.infradead.org; Wed, 19 Jul 2023 05:53:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=dkrlL9aTk/ICSZp+TPV1qqdiTIXX408LSSXoMzvr7FA=; b=C4TPCDqWTUgqqJruUNYdX4ebZR uwh88E/vOeGeiykKvs9pA+KyqIGvPhVC3V2nLpmWp5aVqqeJ/mjFSq4FGK5RAYKzP+K7fAt+c1R5f avCnaDkWUAcS2wb/TChQysVuKwOy+8OP6JxL9w609VcV0BrvBcbqXesf1xv35TLPWH4N3rkIuC8VP JOFzVasaBKpXNc7Q+CcyJE0lSUf67z6nZDxdFwFJDTa5xWdqf+6E9AnBbLPv32iO9oZ29GmmSmlmy 5bbg3SccW/UwNEjgrJZjbFV1nGAOC4M4kvbTaHzqBqYijQxAUY8ZPscTRI2fH7eOSrkK0ISQktCSx SXEzKcHg==; Received: from unicorn.mansr.com ([2001:8b0:ca0d:1::2]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLlJK-00Bcn9-0N for linux-mtd@lists.infradead.org; Tue, 18 Jul 2023 14:04:20 +0000 Received: from raven.mansr.com (raven.mansr.com [IPv6:2001:8b0:ca0d:1::3]) by unicorn.mansr.com (Postfix) with ESMTPS id 5B87715360; Tue, 18 Jul 2023 15:03:14 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id 4C992219B40; Tue, 18 Jul 2023 15:03:14 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , , Julien Su , Jaime Liao , Alvin Zhou , Thomas Petazzoni , JaimeLiao , Alexander Shiyan , Domenico Punzo , Bean Huo Subject: Re: [PATCH v2 3/3] mtd: rawnand: Support for sequential cache reads References: <20230112093637.987838-1-miquel.raynal@bootlin.com> <20230112093637.987838-4-miquel.raynal@bootlin.com> <20230716174917.3a9ca7a7@xps-13> <20230717091900.52ed815a@xps-13> <20230717183645.32ef90b0@xps-13> Date: Tue, 18 Jul 2023 15:03:14 +0100 In-Reply-To: <20230717183645.32ef90b0@xps-13> (Miquel Raynal's message of "Mon, 17 Jul 2023 18:36:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_150418_275183_C6B31E40 X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Miquel Raynal writes: > Hi M=E5ns, > > mans@mansr.com wrote on Mon, 17 Jul 2023 14:11:31 +0100: > >> Miquel Raynal writes: >> = >> > So, I should have done that earlier but, could you please slow the >> > whole operation down, just to see if there is something wrong with the >> > timings or if we should look in another direction. >> > >> > Maybe you could add a boolean to flag if the last CMD was a >> > READCACHESEQ, READCACHESTART or READCACHEEND, and if the flag is >> > true, please get the jiffies before and after each waitrdy and >> > delay_ns. Finally, please print the expected delay and the actual one >> > and compare to see if something was too fast compared to what we >> > expected. = >> = >> Between which points exactly should the delay be measured? Also, there >> is no command called READCACHESTART. Did you mean READSTART or >> something else? > > Yeah, whatever command is specific to sequential cache reads: > https://elixir.bootlin.com/linux/latest/source/drivers/mtd/nand/raw/nand_= base.c#L1218 > https://elixir.bootlin.com/linux/latest/source/drivers/mtd/nand/raw/nand_= base.c#L1228 I'm still not sure what exactly you want to me measure. The waitrdy and ndelay combined, each separately, or something else? -- = M=E5ns Rullg=E5rd ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/