Re: required header files not #included in cdev.h

[Erik Mouw <mouw@nl.linux.org>]

[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]

On Wed, Jan 31, 2007 at 03:36:28AM -0500, Robert P. J. Day wrote:
> On Wed, 31 Jan 2007, Daniel Rodrick wrote:
> > Is this OK?
> 
> typically, this is not OK, but you must be looking at an old version
> of cdev.h.  the latest "git pull" version does, in fact, include the
> appropriate header files:
> 
> #include <linux/kobject.h>
> #include <linux/kdev_t.h>
> #include <linux/list.h>

I guess his "old version" is linux-2.6.19. The include files were fixed
during development from 2.6.19 to 2.6.20-rc1:

erik@arthur:~/git/linux-2.6 > git-log v2.6.19..v2.6.20-rc1 include/linux/cdev.h
commit 5ec68b2e310437e99c297ba04e1afc5297aa6de1
Author: Jan Engelhardt <jengelh@linux01.gwdg.de>
Date:   Wed Dec 6 20:36:14 2006 -0800

    [PATCH] pull in necessary header files for cdev.h

    linux/cdev.h uses struct kobject and other structs and should therefore
    include them.  Currently, a module either needs to add the missing includes
    itself, or, in case a module includes other headers already, needs to put
    <linux/cdev.h> last, which goes against a alphabetically-sorted include
    list.

    Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>


Erik

-- 
They're all fools. Don't worry. Darwin may be slow, but he'll
eventually get them. -- Matthew Lammers in alt.sysadmin.recovery

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]