public inbox for linux-newbie@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Nazarewicz <mina86@tlen.pl>
To: suresh.b.siddha@intel.com
Cc: linux-newbie@vger.kernel.org, venkatesh.pallipadi@intel.com
Subject: Re: remap_pfn_range() and mapping RAM
Date: Tue, 12 May 2009 20:56:19 +0200	[thread overview]
Message-ID: <87zldi2lrg.fsf@erwin.mina86.com> (raw)
In-Reply-To: <1242063629.27006.8590.camel@localhost.localdomain> (Suresh Siddha's message of "Mon, 11 May 2009 10:40:29 -0700")

> On Sun, 2009-05-10 at 09:46 -0700, Michal Nazarewicz wrote:
>> While developing a method for mapping RAM memory into user space
>> I stumbled across Suresh Siddha's commit that "broke" my code:
>> 
>>   commit be03d9e8022030c16abf534e33e185bfc3d40eef
>>   x86, pat: fix warn_on_once() while mapping 0-1MB range with /dev/mem
>> 
>> I've used something along the lines of (error checking removed):
>> 
>> #v+
>> 	return remap_pfn_range(vma, vma->vm_start,
>> 	                       (start >> PAGE_SHIFT) + vma->vm_pgoff
>> 	                       vma->vm_end - vma->vm_start,
>> 	                       vma->vm_page_prot);
>> #v-
>> 
>> Reverting the be03... commit makes it work again but I guess it's not
>> a good way to solve this problem.

Suresh Siddha <suresh.b.siddha@intel.com> writes:
> This mainline commit:
>
> commit 4bb9c5c02153dfc89a6c73a6f32091413805ad7d
> Author: Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com>
> Date:   Thu Mar 12 17:45:27 2009 -0700
>
> has fixed this issue with this portion of the patch:

Ah, thanks, it works great now!  And sorry for the bother (I should've
checked with 2.6.29.2 at least).

-- 
Best regards,                                         _     _
 .o. | Liege of Serenly Enlightened Majesty of      o' \,=./ `o
 ..o | Computer Science,  Michal "mina86" Nazarewicz   (o o)
 ooo +--<mina86*tlen.pl>--<jid:mina86*jabber.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

      reply	other threads:[~2009-05-12 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-10 16:46 remap_pfn_range() and mapping RAM Michal Nazarewicz
2009-05-11 17:40 ` Suresh Siddha
2009-05-12 18:56   ` Michal Nazarewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zldi2lrg.fsf@erwin.mina86.com \
    --to=mina86@tlen.pl \
    --cc=linux-newbie@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox