From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79314C433DB for ; Tue, 2 Feb 2021 20:28:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3796C64E3D for ; Tue, 2 Feb 2021 20:28:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232583AbhBBU2A (ORCPT ); Tue, 2 Feb 2021 15:28:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233369AbhBBU0d (ORCPT ); Tue, 2 Feb 2021 15:26:33 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BAF9C061788; Tue, 2 Feb 2021 12:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=4PFyUqlONvTFczA/ru8USrCCxtLyJRVmXtgqRn7jk0Q=; b=cA2l8yWFP7TqGbGYHST/vX4jJ4 oU/wOCIbjwkQGnFDnNccnYiLD2ycDgnh2uHbNGnb2vX6eedToXdzbjBeQWyVYuubytSu/jleYmrBP LeXVIZnAIVn18r9JviHYmiGrSH141NbC1BhGdyQbc/fu6GtLirjoDAwWjaKrJ2P/MtrUndjTaWp/x DH0+Etj6LuEbB2CvQjYdS0WqOheaBw80sYJL7XnAvShkCy5brdsjrRQ82MF7onQgGKdBa+r/j+Kkg uDkR4af74ZyqvpKJ6rwPBgRxrnY4MjK1hAWIVp3CYVjy/bBuOBX8JgmlvytYxFmsEjvcjeMKdvdUe FIT1kAlg==; Received: from [2601:1c0:6280:3f0::2a53] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l72EN-0007eY-2V; Tue, 02 Feb 2021 20:24:59 +0000 Subject: Re: [PATCH 1/1] ipu3-cio2: Build bridge only if ACPI is enabled To: Sakari Ailus Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , linux-media , Dan Scally , Bingbu Cao , Yong Zhi References: <20210202201440.10613-1-sakari.ailus@linux.intel.com> From: Randy Dunlap Message-ID: <070d3585-e21c-0bef-3740-d38fcd106f25@infradead.org> Date: Tue, 2 Feb 2021 12:24:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210202201440.10613-1-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 2/2/21 12:14 PM, Sakari Ailus wrote: > ipu3-cio2-bridge uses several features of the ACPI framework that have no > meaningful replacement when ACPI is disabled. Instead of adding #ifdefs to > the affected places, only build the bridge code if CONFIG_ACPI is enabled. > > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver") > Signed-off-by: Sakari Ailus Reported-by: Randy Dunlap Acked-by: Randy Dunlap # build-tested Thanks. > --- > Hi Randy, > > Thanks for reporting this. > > This patch should address the problem. > > drivers/media/pci/intel/ipu3/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/intel/ipu3/Kconfig b/drivers/media/pci/intel/ipu3/Kconfig > index 24f4e79fe0cb..dce8274c81e6 100644 > --- a/drivers/media/pci/intel/ipu3/Kconfig > +++ b/drivers/media/pci/intel/ipu3/Kconfig > @@ -20,7 +20,7 @@ config VIDEO_IPU3_CIO2 > > config CIO2_BRIDGE > bool "IPU3 CIO2 Sensors Bridge" > - depends on VIDEO_IPU3_CIO2 > + depends on VIDEO_IPU3_CIO2 && ACPI > help > This extension provides an API for the ipu3-cio2 driver to create > connections to cameras that are hidden in the SSDB buffer in ACPI. > -- ~Randy