From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Re: linux-next: nfs build failure Date: Wed, 18 Jun 2008 18:18:44 -0400 Message-ID: <1213827524.25182.63.camel@localhost> References: <20080618125213.30382b62.sfr@canb.auug.org.au> <1213820042.8233.21.camel@localhost> <485971F2.8000005@oracle.com> <1213823713.25182.35.camel@localhost> <20080618141925.e1e7a90a.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-+BBAvsNYO27yuI6EYiPF" Return-path: Received: from mail-out1.uio.no ([129.240.10.57]:44180 "EHLO mail-out1.uio.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbYFRWSz (ORCPT ); Wed, 18 Jun 2008 18:18:55 -0400 In-Reply-To: <20080618141925.e1e7a90a.randy.dunlap@oracle.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: chuck.lever@oracle.com, Stephen Rothwell , linux-next@vger.kernel.org --=-+BBAvsNYO27yuI6EYiPF Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, 2008-06-18 at 14:19 -0700, Randy Dunlap wrote: > > > > > > You need the same fix in nfs_parse_ipv6_address(). > > > > There is no such printk in nfs_parse_ipv6_address(). > > There is such a 'dfprintk()' in that function in today's linux-next tree, > with the same warning. Gack, you're right. In fact that shows up another bug: #ifdef CONFIG_IPV6 isn't sufficient. The reason the above dfprintk wasn't triggering for me was that you also need to check for CONFIG_IPV6_MODULE. Sigh. Revised patch is attached... Trond --=-+BBAvsNYO27yuI6EYiPF Content-Disposition: inline; filename=linux-2.6.26-023-dont_parse_ipv6_if_no_config_ipv6.dif Content-Type: message/rfc822; name=linux-2.6.26-023-dont_parse_ipv6_if_no_config_ipv6.dif From: Trond Myklebust Date: Wed, 18 Jun 2008 16:04:22 -0400 Subject: NFS: Don't allow IPv6 addresses if CONFIG_IPv6 isn't set Message-Id: <1213827426.25182.61.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Rml4ZXMgYSBjb21waWxlIGZhaWx1cmUgaW4gZnMvbmZzL3N1cGVyLmMKCkFsc28gZml4IHRoZSBj b21waWxlciB3YXJuaW5nczoKICBmcy9uZnMvc3VwZXIuYzo3MjE6IHdhcm5pbmc6IGZpZWxkIHdp ZHRoIHNob3VsZCBoYXZlIHR5cGUg4oCYaW504oCZLCBidXQKICAJCSAgICAgIGFyZ3VtZW50IDIg aGFzIHR5cGUg4oCYc2l6ZV904oCZCiAgZnMvbmZzL3N1cGVyLmM6Nzc2OiB3YXJuaW5nOiBmaWVs ZCB3aWR0aCBzaG91bGQgaGF2ZSB0eXBlIOKAmGludOKAmSwgYnV0CiAgCQkgICAgICBhcmd1bWVu dCAyIGhhcyB0eXBlIOKAmHNpemVfdOKAmQogIGZzL25mcy9zdXBlci5jOjgwOTozOiB3YXJuaW5n OiByZXR1cm5pbmcgdm9pZC12YWx1ZWQgZXhwcmVzc2lvbgogIGZzL25mcy9zdXBlci5jOjgxMToz OiB3YXJuaW5nOiByZXR1cm5pbmcgdm9pZC12YWx1ZWQgZXhwcmVzc2lvbgoKU2lnbmVkLW9mZi1i eTogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbT4KLS0tCgogZnMv bmZzL3N1cGVyLmMgfCAgIDI1ICsrKysrKysrKysrKysrKysrLS0tLS0tLS0KIDEgZmlsZXMgY2hh bmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9mcy9u ZnMvc3VwZXIuYyBiL2ZzL25mcy9zdXBlci5jCmluZGV4IGU2MjgyMGMuLjFkOThlOTUgMTAwNjQ0 Ci0tLSBhL2ZzL25mcy9zdXBlci5jCisrKyBiL2ZzL25mcy9zdXBlci5jCkBAIC03MTgsMTAgKzcx OCwxMCBAQCBzdGF0aWMgdm9pZCBuZnNfcGFyc2VfaXB2NF9hZGRyZXNzKGNoYXIgKnN0cmluZywg c2l6ZV90IHN0cl9sZW4sCiAJc3RydWN0IHNvY2thZGRyX2luICpzaW4gPSAoc3RydWN0IHNvY2th ZGRyX2luICopc2FwOwogCXU4ICphZGRyID0gKHU4ICopJnNpbi0+c2luX2FkZHIuc19hZGRyOwog Ci0JZGZwcmludGsoTU9VTlQsICJORlM6IHBhcnNpbmcgSVB2NCBhZGRyZXNzICUqc1xuIiwKLQkJ CXN0cl9sZW4sIHN0cmluZyk7Ci0KIAlpZiAoc3RyX2xlbiA8PSBJTkVUX0FERFJTVFJMRU4pIHsK KwkJZGZwcmludGsoTU9VTlQsICJORlM6IHBhcnNpbmcgSVB2NCBhZGRyZXNzICUqc1xuIiwKKwkJ CQkoaW50KXN0cl9sZW4sIHN0cmluZyk7CisKIAkJc2luLT5zaW5fZmFtaWx5ID0gQUZfSU5FVDsK IAkJKmFkZHJfbGVuID0gc2l6ZW9mKCpzaW4pOwogCQlpZiAoaW40X3B0b24oc3RyaW5nLCBzdHJf bGVuLCBhZGRyLCAnXDAnLCBOVUxMKSkKQEAgLTczMiw2ICs3MzIsNyBAQCBzdGF0aWMgdm9pZCBu ZnNfcGFyc2VfaXB2NF9hZGRyZXNzKGNoYXIgKnN0cmluZywgc2l6ZV90IHN0cl9sZW4sCiAJKmFk ZHJfbGVuID0gMDsKIH0KIAorI2lmIGRlZmluZWQoQ09ORklHX0lQVjYpIHx8IGRlZmluZWQoQ09O RklHX0lQVjZfTU9EVUxFKQogc3RhdGljIHZvaWQgbmZzX3BhcnNlX2lwdjZfc2NvcGVfaWQoY29u c3QgY2hhciAqc3RyaW5nLCBjb25zdCBzaXplX3Qgc3RyX2xlbiwKIAkJCQkgICAgY29uc3QgY2hh ciAqZGVsaW0sCiAJCQkJICAgIHN0cnVjdCBzb2NrYWRkcl9pbjYgKnNpbjYpCkBAIC03NzIsMTAg Kzc3MywxMCBAQCBzdGF0aWMgdm9pZCBuZnNfcGFyc2VfaXB2Nl9hZGRyZXNzKGNoYXIgKnN0cmlu Zywgc2l6ZV90IHN0cl9sZW4sCiAJdTggKmFkZHIgPSAodTggKikmc2luNi0+c2luNl9hZGRyLmlu Nl91OwogCWNvbnN0IGNoYXIgKmRlbGltOwogCi0JZGZwcmludGsoTU9VTlQsICJORlM6IHBhcnNp bmcgSVB2NiBhZGRyZXNzICUqc1xuIiwKLQkJCXN0cl9sZW4sIHN0cmluZyk7Ci0KIAlpZiAoc3Ry X2xlbiA8PSBJTkVUNl9BRERSU1RSTEVOKSB7CisJCWRmcHJpbnRrKE1PVU5ULCAiTkZTOiBwYXJz aW5nIElQdjYgYWRkcmVzcyAlKnNcbiIsCisJCQkJKGludClzdHJfbGVuLCBzdHJpbmcpOworCiAJ CXNpbjYtPnNpbjZfZmFtaWx5ID0gQUZfSU5FVDY7CiAJCSphZGRyX2xlbiA9IHNpemVvZigqc2lu Nik7CiAJCWlmIChpbjZfcHRvbihzdHJpbmcsIHN0cl9sZW4sIGFkZHIsIFNDT1BFX0RFTElNSVRF UiwgJmRlbGltKSkgewpAQCAtNzg3LDYgKzc4OCwxNCBAQCBzdGF0aWMgdm9pZCBuZnNfcGFyc2Vf aXB2Nl9hZGRyZXNzKGNoYXIgKnN0cmluZywgc2l6ZV90IHN0cl9sZW4sCiAJc2FwLT5zYV9mYW1p bHkgPSBBRl9VTlNQRUM7CiAJKmFkZHJfbGVuID0gMDsKIH0KKyNlbHNlCitzdGF0aWMgdm9pZCBu ZnNfcGFyc2VfaXB2Nl9hZGRyZXNzKGNoYXIgKnN0cmluZywgc2l6ZV90IHN0cl9sZW4sCisJCQkJ ICAgc3RydWN0IHNvY2thZGRyICpzYXAsIHNpemVfdCAqYWRkcl9sZW4pCit7CisJc2FwLT5zYV9m YW1pbHkgPSBBRl9VTlNQRUM7CisJKmFkZHJfbGVuID0gMDsKK30KKyNlbmRpZgogCiAvKgogICog Q29uc3RydWN0IGEgc29ja2FkZHIgYmFzZWQgb24gdGhlIGNvbnRlbnRzIG9mIGEgc3RyaW5nIHRo YXQgY29udGFpbnMKQEAgLTgwNiw5ICs4MTUsOSBAQCBzdGF0aWMgdm9pZCBuZnNfcGFyc2VfaXBf YWRkcmVzcyhjaGFyICpzdHJpbmcsIHNpemVfdCBzdHJfbGVuLAogCQkJY29sb25zKys7CiAKIAlp ZiAoY29sb25zID49IDIpCi0JCXJldHVybiBuZnNfcGFyc2VfaXB2Nl9hZGRyZXNzKHN0cmluZywg c3RyX2xlbiwgc2FwLCBhZGRyX2xlbik7CisJCW5mc19wYXJzZV9pcHY2X2FkZHJlc3Moc3RyaW5n LCBzdHJfbGVuLCBzYXAsIGFkZHJfbGVuKTsKIAllbHNlCi0JCXJldHVybiBuZnNfcGFyc2VfaXB2 NF9hZGRyZXNzKHN0cmluZywgc3RyX2xlbiwgc2FwLCBhZGRyX2xlbik7CisJCW5mc19wYXJzZV9p cHY0X2FkZHJlc3Moc3RyaW5nLCBzdHJfbGVuLCBzYXAsIGFkZHJfbGVuKTsKIH0KIAogLyoK --=-+BBAvsNYO27yuI6EYiPF--