From: Steven Whitehouse <swhiteho@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org
Subject: Re: linux-next: gfs2 tree build failure
Date: Fri, 27 Jun 2008 10:48:41 +0100 [thread overview]
Message-ID: <1214560121.3469.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20080627151225.1fe44918.sfr@canb.auug.org.au>
Hi,
On Fri, 2008-06-27 at 15:12 +1000, Stephen Rothwell wrote:
> Hi Steven,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> ERROR: "gdlm_release_all_locks" [fs/gfs2/locking/dlm/lock_dlm.ko] undefined!
>
> Commit 98ea8e79ff4dfa804690831248881fa6b2145978 ("[GFS2] Remove all_list
> from lock_dlm") missed one call site of the gdlm_release_all_locks
> function which it removed. It also neglected to remove the declaration
> of that function from fs/gfs2/locking/dlm/lock_dlm.h. I have reverted
> that commit.
>
> Sorry, Steven, but I don't see how that could have been build tested ...
> please take a little more care.
>
Sorry. I've just pushed a fix to that. I'm not sure how that slipped
through other than to say that it did build (I just tried it) so that is
why it wasn't spotted,
Steve.
prev parent reply other threads:[~2008-06-27 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 5:12 linux-next: gfs2 tree build failure Stephen Rothwell
2008-06-27 9:48 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214560121.3469.1.camel@localhost.localdomain \
--to=swhiteho@redhat.com \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox