* [PATCH 1/3] x86: suppress sparse returning void warnings
@ 2008-07-17 21:22 Harvey Harrison
2008-07-18 6:13 ` Stephen Rothwell
2008-07-18 11:42 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Harvey Harrison @ 2008-07-17 21:22 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-next
include/asm/paravirt.h:1404:2: warning: returning void-valued expression
include/asm/paravirt.h:1414:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Appeared between next-20080716 and next-20080717
include/asm-x86/paravirt.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/asm-x86/paravirt.h b/include/asm-x86/paravirt.h
index b2aba8f..27c9f22 100644
--- a/include/asm-x86/paravirt.h
+++ b/include/asm-x86/paravirt.h
@@ -1401,7 +1401,7 @@ static inline int __raw_spin_is_contended(struct raw_spinlock *lock)
static __always_inline void __raw_spin_lock(struct raw_spinlock *lock)
{
- return PVOP_VCALL1(pv_lock_ops.spin_lock, lock);
+ PVOP_VCALL1(pv_lock_ops.spin_lock, lock);
}
static __always_inline int __raw_spin_trylock(struct raw_spinlock *lock)
@@ -1411,7 +1411,7 @@ static __always_inline int __raw_spin_trylock(struct raw_spinlock *lock)
static __always_inline void __raw_spin_unlock(struct raw_spinlock *lock)
{
- return PVOP_VCALL1(pv_lock_ops.spin_unlock, lock);
+ PVOP_VCALL1(pv_lock_ops.spin_unlock, lock);
}
#endif
--
1.5.6.3.536.g61aad
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/3] x86: suppress sparse returning void warnings
2008-07-17 21:22 [PATCH 1/3] x86: suppress sparse returning void warnings Harvey Harrison
@ 2008-07-18 6:13 ` Stephen Rothwell
2008-07-18 11:42 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-07-18 6:13 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Ingo Molnar, linux-next, Jeremy Fitzhardinge
[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]
[ Added cc ]
On Thu, 17 Jul 2008 14:22:34 -0700 Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> include/asm/paravirt.h:1404:2: warning: returning void-valued expression
> include/asm/paravirt.h:1414:2: warning: returning void-valued expression
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Appeared between next-20080716 and next-20080717
>
> include/asm-x86/paravirt.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/asm-x86/paravirt.h b/include/asm-x86/paravirt.h
> index b2aba8f..27c9f22 100644
> --- a/include/asm-x86/paravirt.h
> +++ b/include/asm-x86/paravirt.h
> @@ -1401,7 +1401,7 @@ static inline int __raw_spin_is_contended(struct raw_spinlock *lock)
>
> static __always_inline void __raw_spin_lock(struct raw_spinlock *lock)
> {
> - return PVOP_VCALL1(pv_lock_ops.spin_lock, lock);
> + PVOP_VCALL1(pv_lock_ops.spin_lock, lock);
> }
>
> static __always_inline int __raw_spin_trylock(struct raw_spinlock *lock)
> @@ -1411,7 +1411,7 @@ static __always_inline int __raw_spin_trylock(struct raw_spinlock *lock)
>
> static __always_inline void __raw_spin_unlock(struct raw_spinlock *lock)
> {
> - return PVOP_VCALL1(pv_lock_ops.spin_unlock, lock);
> + PVOP_VCALL1(pv_lock_ops.spin_unlock, lock);
> }
>
> #endif
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/3] x86: suppress sparse returning void warnings
2008-07-17 21:22 [PATCH 1/3] x86: suppress sparse returning void warnings Harvey Harrison
2008-07-18 6:13 ` Stephen Rothwell
@ 2008-07-18 11:42 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-07-18 11:42 UTC (permalink / raw)
To: Harvey Harrison; +Cc: linux-next, the arch/x86 maintainers, linux-kernel
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> include/asm/paravirt.h:1404:2: warning: returning void-valued expression
> include/asm/paravirt.h:1414:2: warning: returning void-valued expression
applied to tip/x86/paravirt-spinlocks - thanks Harvey.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-18 11:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-17 21:22 [PATCH 1/3] x86: suppress sparse returning void warnings Harvey Harrison
2008-07-18 6:13 ` Stephen Rothwell
2008-07-18 11:42 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).