* GFS2: new warnings in -next
@ 2008-07-17 21:08 Harvey Harrison
2008-07-18 16:26 ` [PATCH] gfs2: remove nameidata arg from gfs_iop_permission Harvey Harrison
0 siblings, 1 reply; 6+ messages in thread
From: Harvey Harrison @ 2008-07-17 21:08 UTC (permalink / raw)
To: Steven Whitehouse; +Cc: linux-next
Appeared in next-20080717
> fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
> fs/gfs2/ops_inode.c:1153:16: expected int ( *permission )( ... )
> fs/gfs2/ops_inode.c:1153:16: got int ( static [toplevel] *<noident> )( ... )
> fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)
> fs/gfs2/ops_inode.c:1172:16: expected int ( *permission )( ... )
> fs/gfs2/ops_inode.c:1172:16: got int ( static [toplevel] *<noident> )( ... )
> fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
> fs/gfs2/ops_inode.c:1184:16: expected int ( *permission )( ... )
> fs/gfs2/ops_inode.c:1184:16: got int ( static [toplevel] *<noident> )( ... )
> fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type
> fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type
> fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type
Cheers,
Harvey
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] gfs2: remove nameidata arg from gfs_iop_permission
2008-07-17 21:08 GFS2: new warnings in -next Harvey Harrison
@ 2008-07-18 16:26 ` Harvey Harrison
2008-07-18 17:23 ` Al Viro
0 siblings, 1 reply; 6+ messages in thread
From: Harvey Harrison @ 2008-07-18 16:26 UTC (permalink / raw)
To: Steven Whitehouse; +Cc: linux-next, Al Viro
Noticed by sparse
> fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
> fs/gfs2/ops_inode.c:1153:16: expected int ( *permission )( ... )
> fs/gfs2/ops_inode.c:1153:16: got int ( static [toplevel] *<noident> )( ... )
> fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)
> fs/gfs2/ops_inode.c:1172:16: expected int ( *permission )( ... )
> fs/gfs2/ops_inode.c:1172:16: got int ( static [toplevel] *<noident> )( ... )
> fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
> fs/gfs2/ops_inode.c:1184:16: expected int ( *permission )( ... )
> fs/gfs2/ops_inode.c:1184:16: got int ( static [toplevel] *<noident> )( ... )
> fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type
> fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type
> fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Appeared between next-20080716 and next-20080717
fs/gfs2/ops_inode.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
index 1e252df..0456e2b 100644
--- a/fs/gfs2/ops_inode.c
+++ b/fs/gfs2/ops_inode.c
@@ -915,8 +915,7 @@ int gfs2_permission(struct inode *inode, int mask)
return error;
}
-static int gfs2_iop_permission(struct inode *inode, int mask,
- struct nameidata *nd)
+static int gfs2_iop_permission(struct inode *inode, int mask)
{
return gfs2_permission(inode, mask);
}
--
1.5.6.3.569.ga9185
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission
2008-07-18 16:26 ` [PATCH] gfs2: remove nameidata arg from gfs_iop_permission Harvey Harrison
@ 2008-07-18 17:23 ` Al Viro
2008-07-18 17:30 ` Harvey Harrison
0 siblings, 1 reply; 6+ messages in thread
From: Al Viro @ 2008-07-18 17:23 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Steven Whitehouse, linux-next
On Fri, Jul 18, 2008 at 09:26:42AM -0700, Harvey Harrison wrote:
> Noticed by sparse
> > fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
> > fs/gfs2/ops_inode.c:1153:16: expected int ( *permission )( ... )
> > fs/gfs2/ops_inode.c:1153:16: got int ( static [toplevel] *<noident> )( ... )
> > fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)
> > fs/gfs2/ops_inode.c:1172:16: expected int ( *permission )( ... )
> > fs/gfs2/ops_inode.c:1172:16: got int ( static [toplevel] *<noident> )( ... )
> > fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
> > fs/gfs2/ops_inode.c:1184:16: expected int ( *permission )( ... )
> > fs/gfs2/ops_inode.c:1184:16: got int ( static [toplevel] *<noident> )( ... )
> > fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type
> > fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type
> > fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Appeared between next-20080716 and next-20080717
>
> fs/gfs2/ops_inode.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> index 1e252df..0456e2b 100644
> --- a/fs/gfs2/ops_inode.c
> +++ b/fs/gfs2/ops_inode.c
> @@ -915,8 +915,7 @@ int gfs2_permission(struct inode *inode, int mask)
> return error;
> }
>
> -static int gfs2_iop_permission(struct inode *inode, int mask,
> - struct nameidata *nd)
> +static int gfs2_iop_permission(struct inode *inode, int mask)
> {
> return gfs2_permission(inode, mask);
> }
Er? Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function
completely; what tree are you working with?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission
2008-07-18 17:23 ` Al Viro
@ 2008-07-18 17:30 ` Harvey Harrison
2008-07-18 18:04 ` Al Viro
0 siblings, 1 reply; 6+ messages in thread
From: Harvey Harrison @ 2008-07-18 17:30 UTC (permalink / raw)
To: Al Viro; +Cc: Steven Whitehouse, linux-next
On Fri, 2008-07-18 at 18:23 +0100, Al Viro wrote:
> On Fri, Jul 18, 2008 at 09:26:42AM -0700, Harvey Harrison wrote:
> > Noticed by sparse
> > > fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
> > > fs/gfs2/ops_inode.c:1153:16: expected int ( *permission )( ... )
> > > fs/gfs2/ops_inode.c:1153:16: got int ( static [toplevel] *<noident> )( ... )
> > > fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)
> > > fs/gfs2/ops_inode.c:1172:16: expected int ( *permission )( ... )
> > > fs/gfs2/ops_inode.c:1172:16: got int ( static [toplevel] *<noident> )( ... )
> > > fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
> > > fs/gfs2/ops_inode.c:1184:16: expected int ( *permission )( ... )
> > > fs/gfs2/ops_inode.c:1184:16: got int ( static [toplevel] *<noident> )( ... )
> > > fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type
> > > fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type
> > > fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > Appeared between next-20080716 and next-20080717
> >
> > fs/gfs2/ops_inode.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> > index 1e252df..0456e2b 100644
> > --- a/fs/gfs2/ops_inode.c
> > +++ b/fs/gfs2/ops_inode.c
> > @@ -915,8 +915,7 @@ int gfs2_permission(struct inode *inode, int mask)
> > return error;
> > }
> >
> > -static int gfs2_iop_permission(struct inode *inode, int mask,
> > - struct nameidata *nd)
> > +static int gfs2_iop_permission(struct inode *inode, int mask)
> > {
> > return gfs2_permission(inode, mask);
> > }
>
> Er? Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function
> completely; what tree are you working with?
next-20080717 still had it, this was a response to my e-mail from
yesterday noting new sparse warnings. Hence the, appeared between...
If it's gone today, then no worries.
Harvey
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission
2008-07-18 17:30 ` Harvey Harrison
@ 2008-07-18 18:04 ` Al Viro
2008-07-18 18:22 ` Harvey Harrison
0 siblings, 1 reply; 6+ messages in thread
From: Al Viro @ 2008-07-18 18:04 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Steven Whitehouse, linux-next
On Fri, Jul 18, 2008 at 10:30:10AM -0700, Harvey Harrison wrote:
> > Er? Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function
> > completely; what tree are you working with?
>
> next-20080717 still had it, this was a response to my e-mail from
> yesterday noting new sparse warnings. Hence the, appeared between...
>
> If it's gone today, then no worries.
Joy. A mismerge, with Miklos' patch applied both in gfs2 and vfs trees,
with vfs one containing a patch on top of that. Parts of the latter patch
in fs/gfs2/ got dropped at merge in linux-next...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission
2008-07-18 18:04 ` Al Viro
@ 2008-07-18 18:22 ` Harvey Harrison
0 siblings, 0 replies; 6+ messages in thread
From: Harvey Harrison @ 2008-07-18 18:22 UTC (permalink / raw)
To: Al Viro; +Cc: Steven Whitehouse, linux-next
On Fri, 2008-07-18 at 19:04 +0100, Al Viro wrote:
> On Fri, Jul 18, 2008 at 10:30:10AM -0700, Harvey Harrison wrote:
>
> > > Er? Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function
> > > completely; what tree are you working with?
> >
> > next-20080717 still had it, this was a response to my e-mail from
> > yesterday noting new sparse warnings. Hence the, appeared between...
> >
> > If it's gone today, then no worries.
>
> Joy. A mismerge, with Miklos' patch applied both in gfs2 and vfs trees,
> with vfs one containing a patch on top of that. Parts of the latter patch
> in fs/gfs2/ got dropped at merge in linux-next...
I noticed one in security/capability.c in next-20080718 today and sent you a patch.
That was the only new sparse warning in today's linux-next.
Harvey
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-07-18 18:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-17 21:08 GFS2: new warnings in -next Harvey Harrison
2008-07-18 16:26 ` [PATCH] gfs2: remove nameidata arg from gfs_iop_permission Harvey Harrison
2008-07-18 17:23 ` Al Viro
2008-07-18 17:30 ` Harvey Harrison
2008-07-18 18:04 ` Al Viro
2008-07-18 18:22 ` Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).