linux-next: net tree build failure

linux-next: net tree build failure

[Stephen Rothwell]

Hi Dave,

Today's linux-next build (powerpc allyesconfig) failed like this:

net/ipv4/ipvs/ip_vs_proto_tcp.c: In function 'tcp_snat_handler':
net/ipv4/ipvs/ip_vs_proto_tcp.c:208: error: implicit declaration of function 'csum_ipv6_magic'
net/ipv4/ipvs/ip_vs_proto_udp.c: In function 'udp_snat_handler':
net/ipv4/ipvs/ip_vs_proto_udp.c:219: error: implicit declaration of function 'csum_ipv6_magic'

Introduced by commit 0bbdd42b7efa66685b6d74701bcde3a596a3a59d ("IPVS:
Extend protocol DNAT/SNAT and state handlers") which added a call to
csum_ipv6_magic but didn't include net/ip6_checksum.h.  I applied the
following patch.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Sat, 13 Sep 2008 14:37:04 +1000
Subject: [PATCH] net: ip_vs_proto_tcp build fix

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/ipv4/ipvs/ip_vs_proto_tcp.c |    1 +
 net/ipv4/ipvs/ip_vs_proto_udp.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/ipvs/ip_vs_proto_tcp.c b/net/ipv4/ipvs/ip_vs_proto_tcp.c
index 537f616..dd4566e 100644
--- a/net/ipv4/ipvs/ip_vs_proto_tcp.c
+++ b/net/ipv4/ipvs/ip_vs_proto_tcp.c
@@ -18,6 +18,7 @@
 #include <linux/tcp.h>                  /* for tcphdr */
 #include <net/ip.h>
 #include <net/tcp.h>                    /* for csum_tcpudp_magic */
+#include <net/ip6_checksum.h>
 #include <linux/netfilter.h>
 #include <linux/netfilter_ipv4.h>
 
diff --git a/net/ipv4/ipvs/ip_vs_proto_udp.c b/net/ipv4/ipvs/ip_vs_proto_udp.c
index e3ee26b..6eb6039 100644
--- a/net/ipv4/ipvs/ip_vs_proto_udp.c
+++ b/net/ipv4/ipvs/ip_vs_proto_udp.c
@@ -22,6 +22,7 @@
 
 #include <net/ip_vs.h>
 #include <net/ip.h>
+#include <net/ip6_checksum.h>
 
 static struct ip_vs_conn *
 udp_conn_in_get(int af, const struct sk_buff *skb, struct ip_vs_protocol *pp,
-- 
1.5.6.3

Re: linux-next: net tree build failure

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Sat, 13 Sep 2008 15:03:26 +1000

> net: ip_vs_proto_tcp build fix
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Applied, thanks Stephen.

I updated the commit message to mention ip_vs_proto_udp since you
fixed that too :-)

Re: linux-next: net tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi Dave,

On Fri, 12 Sep 2008 23:24:21 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
> I updated the commit message to mention ip_vs_proto_udp since you
> fixed that too :-)

Thanks.  I actually got the errors on two separate builds and laziness
set in :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: net tree build failure (depca)

[Randy Dunlap]

Also this one on i386:

drivers/net/depca.c:404: error: implicit declaration of function 'depca_common_remove'
drivers/net/depca.c:1602: error: static declaration of 'depca_common_remove' follows non-static declaration
drivers/net/depca.c:404: error: previous implicit declaration of 'depca_common_remove' was here
make[2]: *** [drivers/net/depca.o] Error 1



---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Re: linux-next: net tree build failure (depca)

[Harvey Harrison]

On Sat, 2008-09-13 at 08:04 -0700, Randy Dunlap wrote:
> Also this one on i386:
> 
> drivers/net/depca.c:404: error: implicit declaration of function 'depca_common_remove'
> drivers/net/depca.c:1602: error: static declaration of 'depca_common_remove' follows non-static declaration
> drivers/net/depca.c:404: error: previous implicit declaration of 'depca_common_remove' was here
> make[2]: *** [drivers/net/depca.o] Error 1
> 

I'd already sent a patch for that to those responsible:

From: Harvey Harrison <harvey.harrison@gmail.com>
Subject: [PATCH] net: compile fix depca.c

Adding accessors to the ->driver_data field missed a forward
declaration that is needed to compile.

Caused by:
commit 107aeb9753159da848f066b26557f0aaab900a90
Author: Hannes Reinecke <hare@suse.de>
Date:   Wed Sep 10 14:16:04 2008 +0200

    Driver core: Use dev_get_drvdata() accessors

Otherwise:
drivers/net/depca.c:404:9: error: undefined identifier 'depca_common_remove'
drivers/net/depca.c: In function ‘depca_isa_remove’:
drivers/net/depca.c:404: error: implicit declaration of function ‘depca_common_remove’
drivers/net/depca.c: At top level:
drivers/net/depca.c:1601: error: static declaration of ‘depca_common_remove’ follows non-static declaration
drivers/net/depca.c:404: error: previous implicit declaration of ‘depca_common_remove’ was here

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 drivers/net/depca.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/depca.c b/drivers/net/depca.c
index 6ce66e0..d72c6bc 100644
--- a/drivers/net/depca.c
+++ b/drivers/net/depca.c
@@ -398,6 +398,7 @@ static struct mca_driver depca_mca_driver = {
 #endif
 
 static int depca_isa_probe (struct platform_device *);
+static int depca_common_remove(struct net_device *dev);
 
 static int __devexit depca_isa_remove(struct platform_device *pdev)
 {
-- 
1.6.0.1.650.gbf45a

Re: linux-next: net tree build failure

[Simon Horman]

On Sat, Sep 13, 2008 at 03:03:26PM +1000, Stephen Rothwell wrote:
> Hi Dave,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> net/ipv4/ipvs/ip_vs_proto_tcp.c: In function 'tcp_snat_handler':
> net/ipv4/ipvs/ip_vs_proto_tcp.c:208: error: implicit declaration of function 'csum_ipv6_magic'
> net/ipv4/ipvs/ip_vs_proto_udp.c: In function 'udp_snat_handler':
> net/ipv4/ipvs/ip_vs_proto_udp.c:219: error: implicit declaration of function 'csum_ipv6_magic'
> 
> Introduced by commit 0bbdd42b7efa66685b6d74701bcde3a596a3a59d ("IPVS:
> Extend protocol DNAT/SNAT and state handlers") which added a call to
> csum_ipv6_magic but didn't include net/ip6_checksum.h.  I applied the
> following patch.

Hi Stephen, Hi Dave, Hi all,

sorry for letting that one slip through.

I am wondering if it is appropriate to wrap these includes
in #ifdef CONFIG_IP_VS_IPV6, as csum_ipv6_magic() should only
be used in that case.

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Sat, 13 Sep 2008 14:37:04 +1000
> Subject: [PATCH] net: ip_vs_proto_tcp build fix
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  net/ipv4/ipvs/ip_vs_proto_tcp.c |    1 +
>  net/ipv4/ipvs/ip_vs_proto_udp.c |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/net/ipv4/ipvs/ip_vs_proto_tcp.c b/net/ipv4/ipvs/ip_vs_proto_tcp.c
> index 537f616..dd4566e 100644
> --- a/net/ipv4/ipvs/ip_vs_proto_tcp.c
> +++ b/net/ipv4/ipvs/ip_vs_proto_tcp.c
> @@ -18,6 +18,7 @@
>  #include <linux/tcp.h>                  /* for tcphdr */
>  #include <net/ip.h>
>  #include <net/tcp.h>                    /* for csum_tcpudp_magic */
> +#include <net/ip6_checksum.h>
>  #include <linux/netfilter.h>
>  #include <linux/netfilter_ipv4.h>
>  
> diff --git a/net/ipv4/ipvs/ip_vs_proto_udp.c b/net/ipv4/ipvs/ip_vs_proto_udp.c
> index e3ee26b..6eb6039 100644
> --- a/net/ipv4/ipvs/ip_vs_proto_udp.c
> +++ b/net/ipv4/ipvs/ip_vs_proto_udp.c
> @@ -22,6 +22,7 @@
>  
>  #include <net/ip_vs.h>
>  #include <net/ip.h>
> +#include <net/ip6_checksum.h>
>  
>  static struct ip_vs_conn *
>  udp_conn_in_get(int af, const struct sk_buff *skb, struct ip_vs_protocol *pp,
> -- 
> 1.5.6.3

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en

Re: linux-next: net tree build failure (depca)

[Greg KH]

On Sun, Sep 14, 2008 at 01:49:36PM -0700, Harvey Harrison wrote:
> On Sat, 2008-09-13 at 08:04 -0700, Randy Dunlap wrote:
> > Also this one on i386:
> > 
> > drivers/net/depca.c:404: error: implicit declaration of function 'depca_common_remove'
> > drivers/net/depca.c:1602: error: static declaration of 'depca_common_remove' follows non-static declaration
> > drivers/net/depca.c:404: error: previous implicit declaration of 'depca_common_remove' was here
> > make[2]: *** [drivers/net/depca.o] Error 1
> > 
> 
> I'd already sent a patch for that to those responsible:
> 
> From: Harvey Harrison <harvey.harrison@gmail.com>
> Subject: [PATCH] net: compile fix depca.c
> 
> Adding accessors to the ->driver_data field missed a forward
> declaration that is needed to compile.

Merged in, thanks.

greg k-h