From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: linux-next: pci tree build failure Date: Thu, 16 Oct 2008 14:44:01 +1100 Message-ID: <1224128641.8157.502.camel@pasglop> References: <20081016144105.fd0f5d5b.sfr@canb.auug.org.au> Reply-To: benh@kernel.crashing.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:58956 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbYJPDoO (ORCPT ); Wed, 15 Oct 2008 23:44:14 -0400 In-Reply-To: <20081016144105.fd0f5d5b.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: Jesse Barnes , linux-next@vger.kernel.org On Thu, 2008-10-16 at 14:41 +1100, Stephen Rothwell wrote: > Hi Jesse, > > Today's linux-next build (powerpc ppc64_defconfig) failed like this: > > drivers/pci/probe.c: In function 'pci_create_legacy_files': > drivers/pci/probe.c:69: error: 'pci_read_legacy_io' undeclared (first use in this function) > drivers/pci/probe.c:70: error: 'pci_write_legacy_io' undeclared (first use in this function) > drivers/pci/probe.c:80: error: 'pci_mmap_legacy_mem' undeclared (first use in this function) > > Direct cause (probably) is commit 913d3708831ec551ca8560ea2cc793f738df88d6 > ("powerpc/PCI: Add legacy PCI access via sysfs") which I have reverted. > Actually caused by the removal of commit > d965c04f27d4df28b1ce77b0aea6329c07a8e13d ("PCI: Add ability to mmap > legacy_io on some platforms") which the above commit depends on. Yup, Jesse, patch 1/2 is still good :-) It's patch 2/2 that I've been updating 3 times :-) Cheers, Ben