From: "Richard A. Holden III" <aciddeath@gmail.com>
To: linux-next@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Fix arch/x86/kernel/cpu/mtrr/main.c build warning
Date: Thu, 20 Nov 2008 11:03:21 -0700 [thread overview]
Message-ID: <1227204203-32112-1-git-send-email-aciddeath@gmail.com> (raw)
Fix
arch/x86/kernel/cpu/mtrr/main.c: In function 'mtrr_bp_init':
arch/x86/kernel/cpu/mtrr/main.c:1364: warning: 'gran_base' may be used uninitialized in this function
gran_base is only used within the if (debug_print) sections of the for loop, so combine both sections
and move the declaration to within if (debug_print). The overhead of to_size_factor may be a consideration
but the compiler should be able to optimize out the multiple calls.
Signed-off-by: Richard A. Holden III <aciddeath@gmail.com>
---
arch/x86/kernel/cpu/mtrr/main.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
index c091d06..b751e3a 100644
--- a/arch/x86/kernel/cpu/mtrr/main.c
+++ b/arch/x86/kernel/cpu/mtrr/main.c
@@ -1360,20 +1360,16 @@ static int __init mtrr_cleanup(unsigned address_bits)
memset(min_loss_pfn, 0xff, sizeof(min_loss_pfn));
memset(result, 0, sizeof(result));
for (gran_size = (1ULL<<16); gran_size < (1ULL<<32); gran_size <<= 1) {
- char gran_factor;
- unsigned long gran_base;
-
- if (debug_print)
- gran_base = to_size_factor(gran_size >> 10, &gran_factor);
for (chunk_size = gran_size; chunk_size < (1ULL<<32);
chunk_size <<= 1) {
int num_reg;
if (debug_print) {
- char chunk_factor;
- unsigned long chunk_base;
+ char gran_factor, chunk_factor;
+ unsigned long gran_base, chunk_base;
+ gran_base = to_size_factor(gran_size >> 10, &gran_factor);
chunk_base = to_size_factor(chunk_size>>10, &chunk_factor),
printk(KERN_INFO "\n");
printk(KERN_INFO "gran_size: %ld%c chunk_size: %ld%c \n",
--
1.5.6.4
next reply other threads:[~2008-11-20 17:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 18:03 Richard A. Holden III [this message]
2008-11-20 18:03 ` [PATCH] Remove unused variables from the cirrusfb driver Richard A. Holden III
2008-11-20 18:03 ` [PATCH] Remove unused variable from tlv320aic23 codec Richard A. Holden III
2008-11-20 18:56 ` Mark Brown
2008-11-24 13:24 ` [alsa-devel] " Takashi Iwai
2008-11-20 23:34 ` [PATCH] Remove unused variables from the cirrusfb driver Stephen Rothwell
2008-11-21 6:12 ` Richard Holden
2008-11-21 6:40 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227204203-32112-1-git-send-email-aciddeath@gmail.com \
--to=aciddeath@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).