From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Christoph Lameter <cl@linux-foundation.org>,
linux-next@vger.kernel.org, Nick Piggin <npiggin@suse.de>
Subject: Re: linux-next: slab tree build warning
Date: Fri, 06 Feb 2009 10:58:21 +0200 [thread overview]
Message-ID: <1233910701.29891.28.camel@penberg-laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.0902041009050.32130@melkki.cs.Helsinki.FI>
On Wed, 2009-02-04 at 10:11 +0200, Pekka J Enberg wrote:
> On Wed, 4 Feb 2009, Stephen Rothwell wrote:
> > Today's linux-next build (powerpc allnoconfig) produced this warning:
> >
> > mm/slqb.c: In function 'kmem_cache_open':
> > mm/slqb.c:2180: warning: label 'error_lock' defined but not used
> > mm/slqb.c:2176: warning: label 'error_cpu_array' defined but not used
> >
> > Caused by commit 8b9ffd9d52479bd17b5729c9f3acaefa90c7e585 ("slqb: dynamic
> > array allocations").
> >
> > Clearly neither CONFIG_SMP not CONFIG_NUMA is set.
>
> Here's a simple fix for it. It would probably be better to get rid of the
> #ifdefs in kmem_cache_open() with empty static inlines for the
> !CONFIG_SMP and !CONFIG_NUMA cases.
>
> Nick, I did not apply this patch yet so ACK/NAK, please.
I went ahead and merged my patch.
Pekka
next prev parent reply other threads:[~2009-02-06 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 7:38 linux-next: slab tree build warning Stephen Rothwell
2009-02-04 8:11 ` Pekka J Enberg
2009-02-06 8:58 ` Pekka Enberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-04 6:35 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233910701.29891.28.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=linux-next@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox