linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lin Ming <ming.m.lin@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Len Brown <lenb@kernel.org>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"Moore, Robert" <robert.moore@intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: linux-next: acpi tree build failure
Date: Wed, 18 Mar 2009 09:09:01 +0800	[thread overview]
Message-ID: <1237338541.29562.5.camel@minggr> (raw)
In-Reply-To: <20090318115713.bafedc37.sfr@canb.auug.org.au>

On Wed, 2009-03-18 at 08:57 +0800, Stephen Rothwell wrote:
> Hi Len,
> 
> Today's (and several previous day's) linux-next build (i386 allmodconfig)
> failed like this:
> 
> arch/x86/kernel/cpu/cpufreq/longhaul.c: In function 'longhaul_setstate':
> arch/x86/kernel/cpu/cpufreq/longhaul.c:308: error: implicit declaration of function 'acpi_set_register'

Please try below patch,


    ACPI: cpufreq: use new bit register access function
    
    Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
 arch/x86/kernel/cpu/cpufreq/longhaul.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/cpufreq/longhaul.c b/arch/x86/kernel/cpu/cpufreq/longhaul.c
index a4cff5d..4e18d51 100644
--- a/arch/x86/kernel/cpu/cpufreq/longhaul.c
+++ b/arch/x86/kernel/cpu/cpufreq/longhaul.c
@@ -303,7 +303,7 @@ retry_loop:
 		outb(3, 0x22);
 	} else if ((pr != NULL) && pr->flags.bm_control) {
 		/* Disable bus master arbitration */
-		acpi_set_register(ACPI_BITREG_ARB_DISABLE, 1);
+		acpi_write_bit_register(ACPI_BITREG_ARB_DISABLE, 1);
 	}
 	switch (longhaul_version) {
 
@@ -326,7 +326,7 @@ retry_loop:
 	case TYPE_POWERSAVER:
 		if (longhaul_flags & USE_ACPI_C3) {
 			/* Don't allow wakeup */
-			acpi_set_register(ACPI_BITREG_BUS_MASTER_RLD, 0);
+			acpi_write_bit_register(ACPI_BITREG_BUS_MASTER_RLD, 0);
 			do_powersaver(cx->address, clock_ratio_index, dir);
 		} else {
 			do_powersaver(0, clock_ratio_index, dir);
@@ -339,7 +339,7 @@ retry_loop:
 		outb(0, 0x22);
 	} else if ((pr != NULL) && pr->flags.bm_control) {
 		/* Enable bus master arbitration */
-		acpi_set_register(ACPI_BITREG_ARB_DISABLE, 0);
+		acpi_write_bit_register(ACPI_BITREG_ARB_DISABLE, 0);
 	}
 	outb(pic2_mask,0xA1);	/* restore mask */
 	outb(pic1_mask,0x21);


> 
> (http://kisskb.ellerman.id.au/kisskb/target/421/)
> 
> Caused by commit e2f34512879026beb26827c14b1d1e67c07f2858 ("ACPICA:
> Rename ACPI bit register access functions").
> 


  reply	other threads:[~2009-03-18  1:09 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18  0:57 linux-next: acpi tree build failure Stephen Rothwell
2009-03-18  1:09 ` Lin Ming [this message]
2009-03-18  3:27   ` Stephen Rothwell
2009-03-27 20:49     ` Len Brown
  -- strict thread matches above, loose matches on Subject: below --
2009-12-14  1:20 Stephen Rothwell
2009-12-14 19:20 ` Bjorn Helgaas
2009-12-15  4:57 ` Bjorn Helgaas
2009-12-15 22:37   ` Len Brown
2009-12-15 23:28     ` Stephen Rothwell
2009-12-16  2:28     ` Stephen Rothwell
2009-09-26  2:15 Stephen Rothwell
2009-09-26  3:11 ` Bjorn Helgaas
2009-09-27  1:27   ` Crane Cai
2009-09-27  7:54     ` Len Brown
2009-09-01  2:57 Stephen Rothwell
2009-09-07 13:46 ` Stephen Rothwell
2009-09-08  0:47   ` Zhang Rui
2009-09-09  4:02     ` Len Brown
2009-09-09  5:45       ` Stephen Rothwell
2009-06-30  3:16 Stephen Rothwell
2009-07-06  6:18 ` Stephen Rothwell
2009-07-07  3:17 ` Len Brown
2009-07-07  3:53   ` Stephen Rothwell
2009-04-24  4:46 Stephen Rothwell
2009-04-24 15:15 ` Len Brown
2009-02-24  4:37 Stephen Rothwell
2009-03-03  1:47 ` Stephen Rothwell
2009-03-16  5:10   ` Stephen Rothwell
2009-03-27 20:58   ` Len Brown
2009-02-02  2:22 Stephen Rothwell
2009-02-05  2:13 ` Stephen Rothwell
2009-02-05  5:00   ` Greg KH
2009-02-07  4:06     ` Len Brown
2009-02-07  5:32       ` Greg KH
2008-10-15  5:08 Stephen Rothwell
2008-10-15  5:15 ` Shaohua Li
2008-10-15  4:51 Stephen Rothwell
2008-08-12  3:16 Stephen Rothwell
2008-08-12  7:06 ` Andi Kleen
2008-08-12 20:07   ` Carlos Corbacho
2008-08-12 21:29 ` Carlos Corbacho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237338541.29562.5.camel@minggr \
    --to=ming.m.lin@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=robert.moore@intel.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).