From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Christoph Lameter <cl@linux-foundation.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: slab tree build failure
Date: Mon, 22 Jun 2009 12:09:02 +0300 [thread overview]
Message-ID: <1245661742.18751.32.camel@penberg-laptop> (raw)
In-Reply-To: <1245408008.16880.9.camel@pasglop>
On Fri, 2009-06-19 at 20:40 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2009-06-19 at 14:16 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> >
> > mm/slqb.c:75: error: 'SLAB_GFP_BOOT_MASK' undeclared here (not in a function)
> >
> > Caused by commit df548b0bbaf2d4d16ce52d2f5ccdc1cfded70e06 ("SLQB: Fix
> > early boot allocations") from the slab tree interacting with commit
> > dcce284a259373f9e5570f2e33f79eca84fcf565 ("mm: Extend gfp masking to the
> > page allocator") that entered Linus' tree today.
> >
> > I have applied this patch for today:
>
> The right fix is to remove slab_gfp_mask from slqb.c and use
> the global gfp_allowed_mask instead.
This should be fixed now in slab.git. Something in SQLB is still
enabling interrupts during early boot but I don't have the time to look
at it in more detail right now.
Pekka
next prev parent reply other threads:[~2009-06-22 9:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 4:16 linux-next: slab tree build failure Stephen Rothwell
2009-06-19 10:40 ` Benjamin Herrenschmidt
2009-06-22 9:09 ` Pekka Enberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-08 3:44 Stephen Rothwell
2009-12-07 4:11 Stephen Rothwell
2009-09-07 5:37 Stephen Rothwell
2009-09-07 6:10 ` Pekka Enberg
2009-09-07 7:31 ` Stephen Rothwell
2009-09-07 7:43 ` Pekka Enberg
2009-09-07 8:29 ` Stephen Rothwell
2009-09-07 9:04 ` Heiko Carstens
2009-09-07 9:22 ` Pekka Enberg
2009-09-07 8:35 ` Catalin Marinas
2009-09-08 16:32 ` Luis R. Rodriguez
2008-11-03 4:42 Stephen Rothwell
2008-11-03 5:14 ` Dave Chinner
2008-11-03 9:38 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245661742.18751.32.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=benh@kernel.crashing.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).