Re: [PATCH] Fix Warnings from net/netlink/genetlink.c

Stephen Hemminger
2009-08-12T03:25:05Z

On Tue, 11 Aug 2009 16:57:41 -0700
Marcel Holtmann <marcel@holtmann.org> wrote:

> Hi Vibi,
>
> > net/netlink/genetlink.c: In function `genl_register_mc_group':
> > net/netlink/genetlink.c:139: warning: 'err' might be used uninitialized in this function
> >
> > Signed-off-by: vibi sreenivasan <vibi_sreenivasan@cms.com>
> > ---
> > net/netlink/genetlink.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
> > index 575c643..66f6ba0 100644
> > --- a/net/netlink/genetlink.c
> > +++ b/net/netlink/genetlink.c
> > @@ -136,7 +136,7 @@ int genl_register_mc_group(struct genl_family *family,
> > {
> > int id;
> > unsigned long *new_groups;
> > - int err;
> > + int err = 0;
> >
> > BUG_ON(grp->name[0] == '\0');
>
> this looks fishy. How does gcc thinks this variable is uninitialized. If
> I look at the code in Linus' tree, I don't see it.

Agreed, and the line numbers are off.

--