linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE
Date: Thu, 08 Oct 2009 20:29:23 +0200	[thread overview]
Message-ID: <1255026563.3713.28.camel@johannes.local> (raw)
In-Reply-To: <20091008080615.09c8b803.randy.dunlap@oracle.com>

On Thu, 2009-10-08 at 08:06 -0700, Randy Dunlap wrote:

> > It's kinda strange though that you can select wireless drivers without
> > selecting WIRELESS. Maybe the solution is as simple as making WLAN
> > (drivers/net/wireless/Kconfig) depend on WIRELESS?
> 
> Yes, I think that would be a very good start.

On the other hand, of course, the whole WIRELESS thing is somewhat
stupid. How about this?

johannes

From: Johannes Berg <johannes@sipsolutions.net>
Subject: wireless: make wireless drivers select core

It is somewhat non-sensical to allow selecting wireless
drivers without showing wireless core code options, and
since the wext refactoring this has made it possible to
generate configurations that will not build. Avoid this
and make wireless drivers select the wireless options.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 drivers/net/wireless/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- wireless-testing.orig/drivers/net/wireless/Kconfig	2009-10-08 20:25:04.000000000 +0200
+++ wireless-testing/drivers/net/wireless/Kconfig	2009-10-08 20:27:38.000000000 +0200
@@ -5,6 +5,7 @@
 menuconfig WLAN
 	bool "Wireless LAN"
 	depends on !S390
+	select WIRELESS
 	default y
 	---help---
 	  This section contains all the pre 802.11 and 802.11 wireless

  reply	other threads:[~2009-10-08 18:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07  6:35 linux-next: Tree for October 7 Stephen Rothwell
2009-10-07 10:54 ` next-20091007 - comedi driver build breaks on S390x Kamalesh Babulal
2009-10-07 13:07   ` Greg KH
2009-10-07 15:34     ` Martin Schwidefsky
2009-10-07 17:27       ` Greg KH
2009-10-08  8:55         ` Martin Schwidefsky
2009-10-07 17:21 ` [PATCH -next] drbd: needs __ratelimit() Randy Dunlap
     [not found]   ` <20091007102153.1a19119b.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-07 17:26     ` Jens Axboe
2009-10-07 17:22 ` [PATCH -next] vbus: proxy uses, select IOQ Randy Dunlap
2009-10-07 18:19   ` Gregory Haskins
2009-10-07 17:52 ` linux-next: Tree for October 7 (libertas build failure) Randy Dunlap
2009-10-07 18:12   ` Dan Williams
     [not found]     ` <1254939120.16001.45.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-10-07 22:34       ` Johannes Berg
     [not found] ` <20091007173517.abfcfa2a.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-10-07 17:57   ` linux-next: Tree for October 7 (wireless/wext) Randy Dunlap
2009-10-07 21:07     ` [PATCH] wireless: make WEXT_SPY and WEXT_PRIV select WEXT_CORE John W. Linville
2009-10-07 21:55       ` Randy Dunlap
     [not found]         ` <4ACD0E5A.7060106-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-07 22:34           ` Johannes Berg
     [not found]             ` <1254954842.3713.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-07 22:54               ` Randy Dunlap
2009-10-07 23:14                 ` Johannes Berg
     [not found]                   ` <1254957256.3713.10.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-08  0:12                     ` Randy Dunlap
     [not found]                       ` <20091007171235.d40f0cc2.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-08  9:48                         ` Johannes Berg
2009-10-08 15:06                           ` Randy Dunlap
2009-10-08 18:29                             ` Johannes Berg [this message]
2009-10-09 16:06                               ` Randy Dunlap
2009-10-09 16:14                                 ` Johannes Berg
     [not found]                                   ` <1255104846.4095.2.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-09 16:32                                     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255026563.3713.28.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).