* linux-next: tip tree build warning
@ 2010-02-01 7:22 Stephen Rothwell
2010-02-01 10:13 ` [PATCH] sched: Remove unused update_shares_locked() Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2010-02-01 7:22 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
Hi all,
Today's linux-next build (powerpc allyesconfig) produced this warning:
kernel/sched.c:1636: warning: 'update_shares_locked' defined but not used
Introduced by commit f492e12ef050e02bf0185b6b57874992591b9be1 ("sched:
Remove load_balance_newidle()").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] sched: Remove unused update_shares_locked()
2010-02-01 7:22 linux-next: tip tree build warning Stephen Rothwell
@ 2010-02-01 10:13 ` Peter Zijlstra
2010-02-01 23:22 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2010-02-01 10:13 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next,
linux-kernel
On Mon, 2010-02-01 at 18:22 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (powerpc allyesconfig) produced this warning:
>
> kernel/sched.c:1636: warning: 'update_shares_locked' defined but not used
>
> Introduced by commit f492e12ef050e02bf0185b6b57874992591b9be1 ("sched:
> Remove load_balance_newidle()").
Hmm, you're quite right indeed, that removed the only user of that
function.
---
Subject: sched: Remove unused update_shares_locked()
Commit f492e12ef050e02bf0185b6b57874992591b9be1 ("sched: Remove
load_balance_newidle()") removed the only user of this function, so
remove it too.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/sched.c | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 876e7c1..b5c8b44 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -1633,16 +1633,6 @@ static void update_shares(struct sched_domain *sd)
}
}
-static void update_shares_locked(struct rq *rq, struct sched_domain *sd)
-{
- if (root_task_group_empty())
- return;
-
- raw_spin_unlock(&rq->lock);
- update_shares(sd);
- raw_spin_lock(&rq->lock);
-}
-
static void update_h_load(long cpu)
{
if (root_task_group_empty())
@@ -1657,10 +1647,6 @@ static inline void update_shares(struct sched_domain *sd)
{
}
-static inline void update_shares_locked(struct rq *rq, struct sched_domain *sd)
-{
-}
-
#endif
#ifdef CONFIG_PREEMPT
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] sched: Remove unused update_shares_locked()
2010-02-01 10:13 ` [PATCH] sched: Remove unused update_shares_locked() Peter Zijlstra
@ 2010-02-01 23:22 ` Stephen Rothwell
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2010-02-01 23:22 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
Hi Peter,
On Mon, 01 Feb 2010 11:13:39 +0100 Peter Zijlstra <peterz@infradead.org> wrote:
>
> Subject: sched: Remove unused update_shares_locked()
Thanks for that.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-01 23:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-01 7:22 linux-next: tip tree build warning Stephen Rothwell
2010-02-01 10:13 ` [PATCH] sched: Remove unused update_shares_locked() Peter Zijlstra
2010-02-01 23:22 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).