From: Dan Williams <dcbw@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
akpm <akpm@linux-foundation.org>,
Andrey Yurovsky <andrey@cozybit.com>,
Colin McCabe <colin@cozybit.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH -next] libertas/if_spi: needs linux/semaphore.h
Date: Thu, 04 Feb 2010 13:52:57 -0800 [thread overview]
Message-ID: <1265320377.4290.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20100203153107.28184ef0.randy.dunlap@oracle.com>
On Wed, 2010-02-03 at 15:31 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> libertas/if_spi.c needs to #include linux/semaphore.h to fix build errors:
>
> drivers/net/wireless/libertas/if_spi.c:59: error: field 'spi_ready' has incomplete type
> drivers/net/wireless/libertas/if_spi.c:60: error: field 'spi_thread_terminated' has incomplete type
> drivers/net/wireless/libertas/if_spi.c:785: error: implicit declaration of function 'down_interruptible'
> drivers/net/wireless/libertas/if_spi.c:787: error: implicit declaration of function 'up'
> drivers/net/wireless/libertas/if_spi.c:834: error: implicit declaration of function 'down'
> drivers/net/wireless/libertas/if_spi.c:943: error: implicit declaration of function 'sema_init'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> drivers/net/wireless/libertas/if_spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20100203.orig/drivers/net/wireless/libertas/if_spi.c
> +++ linux-next-20100203/drivers/net/wireless/libertas/if_spi.c
> @@ -23,6 +23,7 @@
> #include <linux/kthread.h>
> #include <linux/list.h>
> #include <linux/netdevice.h>
> +#include <linux/semaphore.h>
> #include <linux/spi/libertas_spi.h>
> #include <linux/spi/spi.h>
>
prev parent reply other threads:[~2010-02-04 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 6:26 linux-next: Tree for February 3 Stephen Rothwell
2010-02-03 23:31 ` [PATCH -next] libertas/if_spi: needs linux/semaphore.h Randy Dunlap
2010-02-04 21:52 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265320377.4290.7.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrey@cozybit.com \
--cc=colin@cozybit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).