From: David Woodhouse <dwmw2@infradead.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: geert@linux-m68k.org, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
maximlevitsky@gmail.com, linux-arch@vger.kernel.org
Subject: Re: DMA_ERROR_CODE (was: Re: linux-next: build failure after merge of the final tree)
Date: Thu, 11 Mar 2010 09:30:09 -0800 [thread overview]
Message-ID: <1268328609.23872.9.camel@macbook.infradead.org> (raw)
In-Reply-To: <20100311091506J.fujita.tomonori@lab.ntt.co.jp>
On Thu, 2010-03-11 at 09:15 +0900, FUJITA Tomonori wrote:
> On Wed, 10 Mar 2010 12:03:37 +0100
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> > On Mon, Mar 1, 2010 at 10:40, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > >
> > > drivers/mtd/nand/r852.c:22: error: 'enable_dma' redeclared as different kind of symbol
> > > arch/powerpc/include/asm/dma.h:189: note: previous definition of 'enable_dma' was here
> > > drivers/mtd/nand/r852.c: In function 'r852_engine_enable':
> > > drivers/mtd/nand/r852.c:545: error: implicit declaration of function 'msleep'
> > >
> > > Caused by commit 67e054e919248fa1db93de727fb9ad49eb700642 ("mtd: nand:
> > > Add driver for Ricoh xD/SmartMedia reader") from the mtd.
> > >
> > > I applied the following patch for today.
> > >
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Date: Mon, 1 Mar 2010 20:21:06 +1100
> > > Subject: [PATCH] mtd: nand: fix name space clash
> > >
> > > and include delay.h for msleep().
> >
> > Another issue is that this driver uses DMA_ERROR_CODE, which is currently
> > defined on powerpc/sparc/x86 only.
>
> Why can't use dma_mapping_error()?
http://git.infradead.org/mtd-2.6.git/commitdiff/0c82d3ce
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
prev parent reply other threads:[~2010-03-11 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 11:03 DMA_ERROR_CODE (was: Re: linux-next: build failure after merge of the final tree) Geert Uytterhoeven
2010-03-11 0:15 ` FUJITA Tomonori
2010-03-11 17:30 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268328609.23872.9.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).