From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: DMA_ERROR_CODE (was: Re: linux-next: build failure after merge of the final tree) Date: Thu, 11 Mar 2010 09:30:09 -0800 Message-ID: <1268328609.23872.9.camel@macbook.infradead.org> References: <10f740e81003100303m5a4ffb45t26c380b4ef3dec37@mail.gmail.com> <20100311091506J.fujita.tomonori@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:59100 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752593Ab0CKRai (ORCPT ); Thu, 11 Mar 2010 12:30:38 -0500 In-Reply-To: <20100311091506J.fujita.tomonori@lab.ntt.co.jp> Sender: linux-next-owner@vger.kernel.org List-ID: To: FUJITA Tomonori Cc: geert@linux-m68k.org, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, maximlevitsky@gmail.com, linux-arch@vger.kernel.org On Thu, 2010-03-11 at 09:15 +0900, FUJITA Tomonori wrote: > On Wed, 10 Mar 2010 12:03:37 +0100 > Geert Uytterhoeven wrote: > > > On Mon, Mar 1, 2010 at 10:40, Stephen Rothwell wrote: > > > After merging the final tree, today's linux-next build (powerpc > > > allyesconfig) failed like this: > > > > > > drivers/mtd/nand/r852.c:22: error: 'enable_dma' redeclared as different kind of symbol > > > arch/powerpc/include/asm/dma.h:189: note: previous definition of 'enable_dma' was here > > > drivers/mtd/nand/r852.c: In function 'r852_engine_enable': > > > drivers/mtd/nand/r852.c:545: error: implicit declaration of function 'msleep' > > > > > > Caused by commit 67e054e919248fa1db93de727fb9ad49eb700642 ("mtd: nand: > > > Add driver for Ricoh xD/SmartMedia reader") from the mtd. > > > > > > I applied the following patch for today. > > > > > > From: Stephen Rothwell > > > Date: Mon, 1 Mar 2010 20:21:06 +1100 > > > Subject: [PATCH] mtd: nand: fix name space clash > > > > > > and include delay.h for msleep(). > > > > Another issue is that this driver uses DMA_ERROR_CODE, which is currently > > defined on powerpc/sparc/x86 only. > > Why can't use dma_mapping_error()? http://git.infradead.org/mtd-2.6.git/commitdiff/0c82d3ce -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation