From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Levitsky Subject: Re: [PATCH -next] mtd/nand/r852: fix build for CONFIG_PCI disabled Date: Thu, 11 Mar 2010 22:59:29 +0200 Message-ID: <1268341169.9708.6.camel@localhost.localdomain> References: <20100301210210.c6f465e6.sfr@canb.auug.org.au> <4B8C378B.2090400@oracle.com> <1267531329.10734.1.camel@maxim-laptop> <4B991A6F.1080006@oracle.com> <4B991B9B.8070809@oracle.com> <4B992408.7040608@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f227.google.com ([209.85.220.227]:45265 "EHLO mail-fx0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824Ab0CKU7e (ORCPT ); Thu, 11 Mar 2010 15:59:34 -0500 In-Reply-To: <4B992408.7040608@oracle.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , "Rafael J. Wysocki" , David Woodhouse , linux-mtd@lists.infradead.org On Thu, 2010-03-11 at 09:10 -0800, Randy Dunlap wrote: > > > > Sorry, it's there, but there are still build errors. > > I will look at those... > > > > > From: Randy Dunlap > > r852 fails to build when CONFIG_PCI is not enabled since it uses > pci_*() calls and is a PCI driver, so it should depend on PCI > to prevent build errors. > It should also #include . Folks, sorry for Kconfig mess, I didn't test it well enough it seems... However, I #include the in r852.h, so I don't think it is necessary here. Also, I disagree with the unconditional dependency on nand in sm_ftl. The purpose of CONFIG_SM_FTL_MUSEUM is solely to make it independent of nand. I'll look at how to fix that properly. Best regards, Maxim Levitsky